azurerm_cost_management_scheduled_action - New resource

[aristosvo]

Fixes #21198

Acceptance Tests

TODO

• Docs
• Extra tests

[aristosvo]

Rebased, tests still passing

[stephybun]

Thanks for this PR @aristosvo! I've done a first pass through and left some comments and questions in line. Once those are resolved we can take another look through and run the tests.

[stephybun]

Are there other useful scheduled action kinds that might want to be exposed in future? If so it might be good to specify that in the resource name, i.e. azurerm_subscription_cost_management_email_scheduled_action and to remove the email prefix for all of the arguments.

If not happy to the keep the name as is since otherwise they get a bit long 😅

[aristosvo]

The same API is also used to create azurerm_cost_anomaly_alert (Kind=Insight Alert), you could argue that this one is a azurerm_scheduled_cost_email or azurerm_cost_management_scheduled_view_email.., the question here is what the scope is of this resource and what Microsoft seems fit long term. It might be that this resource is extended to have more Kinds, or that it might extend to email multiple resource types: next to views also CSV files based on a query, whatsoever.

In the API docs they are also talking about reports, in the Cost Management Docs it is referred to as scheduled_alerts..

Options:

• azurerm_cost_management_scheduled_view_email (Most precise technical description)
• azurerm_cost_management_scheduled_report (Best functional description IMHO)
• azurerm_cost_management_scheduled_alert (Closest to docs, confusing to me tbh)

Your choice 😵

[stephybun]

Thanks so much @aristosvo! I have one final remark about some (I think) unused files. But other than that this looks like it's good to go!

[aristosvo]

Thanks so much @aristosvo! I have one final remark about some (I think) unused files. But other than that this looks like it's good to go!

Hi @stephybun! Thanks! What is your opinion about the name of the resource, is that something that is still open for discussion or should we leave it like this for now?

[stephybun]

I think the name is okay as is for now, if we need more granularity in the future then it shouldn't conflict with anything... hoping that doesn't come bite me on the bum later on 😅
Thanks again @aristosvo! LGTM 🌻

[github-actions]

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.