Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_service_plan - New SKUs #21371

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Apr 11, 2023

Fixes #21365

AccTests

  • Due to limited availability of the new Service Plans yet (az appservice list-locations --sku P1mV3), we'd probably need to make some changes to the test setup
export ARM_TEST_LOCATION="northeurope"
❯ go install && make acctests SERVICE='appservice' TESTARGS='-run=TestAccServicePlan_memoryOptimized'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccServicePlan_memoryOptimized -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccServicePlan_memoryOptimized
=== PAUSE TestAccServicePlan_memoryOptimized
=== CONT  TestAccServicePlan_memoryOptimized
--- PASS: TestAccServicePlan_memoryOptimized (122.91s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice124.851s

@jackofallops
Copy link
Member

jackofallops commented Apr 11, 2023

Hi @aristosvo - Do you have links to docs supporting the region availability of the new SKU's for context for this PR to be reviewed?

@aristosvo
Copy link
Collaborator Author

aristosvo commented Apr 11, 2023

Based on the announcement: H1.

Availability of the new plans is rolling out in H1 2023 across the Azure regions

Availability differs per SKU type:

SKU Regions
I6v2 36 (az appservice list-locations --sku I6v2)
P1mV3 5 (az appservice list-locations --sku P1mV3)

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - one comment below to address and I'll PR the pre-requisite change so we can run the new test too.

Thanks

internal/services/appservice/service_plan_resource_test.go Outdated Show resolved Hide resolved
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 👍

@jackofallops
Copy link
Member

New test looks good

image

@jackofallops jackofallops added this to the v3.52.0 milestone Apr 11, 2023
@jackofallops jackofallops merged commit a5dfcfa into hashicorp:main Apr 11, 2023
jackofallops added a commit that referenced this pull request Apr 11, 2023
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new app service plan SKUs
2 participants