Orbital resources: bump API version from 2022-03-01 to 2022-11-01 #21405
Conversation
jiaweitao001
commented
Apr 13, 2023
jiaweitao001
commented
- Bumped orbital resources' API version to 2022-11-01.
There was a problem hiding this comment.
Thanks for this PR - I've taken a look through and left some comments inline, but we shouldn't be raising an error when these values are empty in the API response (since how are users supposed to resolve that?) - instead these should be flagged as empty strings in the config so that the user can opt to apply an update for them to resolve this issue?
Thanks!
| } else { | ||
| return fmt.Errorf("contact profile reservation start time is missing %s", *id) |
There was a problem hiding this comment.
why is this returned as an error? this should be flagged as missing in the diff
| } else { | ||
| return fmt.Errorf("contact profile reservation end time is missing %s", *id) |
There was a problem hiding this comment.
why is this returned as an error? this should be flagged as missing in the diff
| } else { | ||
| return fmt.Errorf("required properties are missing %s", *id) | ||
| return fmt.Errorf("contact profile ground station name is missing %s", *id) |
There was a problem hiding this comment.
why is this returned as an error? this should be flagged as missing in the diff
| } else { | ||
| return fmt.Errorf("contact profile id is missing %s", *id) |
There was a problem hiding this comment.
why is this returned as an error? this should be flagged as missing in the diff
|
Thanks @tombuildsstuff , updated as suggested. |
Fixes #2395 No longer needed as of hashicorp/terraform-provider-azurerm#21405
Fixes #2395 No longer needed as of hashicorp/terraform-provider-azurerm#21405
|
This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
