Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2 application_stack support for linux_web_app #21420

Merged

Conversation

mateuszmalek
Copy link
Contributor

Azure allows to use PHP 8.2 as runtime stack for Linux Web App.

  /  _  \ __________ _________   ____  
 /  /_\  \\___   /  |  \_  __ \_/ __ \ 
/    |    \/    /|  |  /|  | \/\  ___/ 
\____|__  /_____ \____/ |__|    \___  >
        \/      \/                  \/ 
A P P   S E R V I C E   O N   L I N U X

Documentation: http://aka.ms/webapp-linux
PHP quickstart: https://aka.ms/php-qs
PHP version : 8.2.1
Note: Any data outside '/home' is not persisted
root@XXX:/home# php -v
PHP 8.2.1 (cli) (built: Jan 15 2023 09:03:53) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.1, Copyright (c) Zend Technologies
az webapp list-runtimes --os linux
[
  (...)
  "PHP:8.2",
  "PHP:8.1",
  "PHP:8.0",
  (...)
]

This PR also removes support for PHP 7.4 which support was ended on 28.11.2022: https://azure.microsoft.com/en-us/updates/community-support-for-php-74-is-ending-on-28-november-2022/

@mateuszmalek mateuszmalek changed the title Add PHP 8.2 application_stack support for linux_web_app Add PHP 8.2 application_stack support for linux_web_app Apr 14, 2023
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mateuszmalek - just a couple minor things to address below. Could you also add a test for the new version number (or update the test for 7.4 with 8.2?)

Thanks!

website/docs/r/linux_web_app.html.markdown Outdated Show resolved Hide resolved
website/docs/r/linux_web_app_slot.html.markdown Outdated Show resolved Hide resolved
- update documentation about 7.4 deprecation
- add missing tests for PHP 8.1 & 8.2
@mateuszmalek
Copy link
Contributor Author

@jackofallops I've made adjustments according to your feedback.
I've also added test for 8.1 (which was missing) as well as introduced 8.2.

@jackofallops jackofallops self-assigned this Apr 17, 2023
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mateuszmalek - this LGTM now 👍

@jackofallops
Copy link
Member

Tests look good:

image

@jackofallops jackofallops merged commit 211b70f into hashicorp:main Apr 19, 2023
@github-actions github-actions bot added this to the v3.53.0 milestone Apr 19, 2023
jackofallops added a commit that referenced this pull request Apr 19, 2023
@mateuszmalek mateuszmalek deleted the feature/linux_web_app-php8.2-support branch April 19, 2023 17:48
@github-actions
Copy link

This functionality has been released in v3.53.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants