New Resource: azurerm_kubernetes_flux_configuration and azurerm_arc_kubernetes_flux_configuration

[ms-zhenhua]

Swagger:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2022-11-01/fluxconfiguration.json

Test Result:

--- PASS: TestAccKubernetesFluxConfiguration_requiresImport (1056.82s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithSasToken (1067.92s)
--- PASS: TestAccKubernetesFluxConfiguration_basic (1145.67s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithServicePrincipalSecret (1149.14s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithManagedIdentity (1156.88s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithServicePrincipalCertificate (1220.02s)
--- PASS: TestAccKubernetesFluxConfiguration_azureBlobWithAccountKey (1223.27s)
--- PASS: TestAccKubernetesFluxConfiguration_update (1234.21s)
--- PASS: TestAccKubernetesFluxConfiguration_privateRepositoryWithSshKey (1263.36s)
--- PASS: TestAccKubernetesFluxConfiguration_complete (1336.38s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/containers 1347.280s

--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithAccountKey (1096.93s)
--- PASS: TestAccArcKubernetesFluxConfiguration_requiresImport (1114.43s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithServicePrincipalSecret (1139.91s)
--- PASS: TestAccArcKubernetesFluxConfiguration_basic (1154.78s)
--- PASS: TestAccArcKubernetesFluxConfiguration_privateRepositoryWithSshKey (1156.55s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithServicePrincipalCertificate (1178.27s)
--- PASS: TestAccArcKubernetesFluxConfiguration_update (1269.06s)
--- PASS: TestAccArcKubernetesFluxConfiguration_azureBlobWithSasToken (1305.40s)
--- PASS: TestAccArcKubernetesFluxConfiguration_complete (1366.15s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/arckubernetes 1409.659s

[stephybun]

Thanks for this @ms-zhenhua.

I made a first pass through and left some comments that need to be addressed. Once those are done and applied to both resources we can take another look through!

[ms-zhenhua]

Hi @stephybun, thank you for your review. I have resolved all comments. Kindly help take another look.

[stephybun]

Thanks @ms-zhenhua - would you mind taking a look at the comment I left on the container_id suggestion?

[ms-zhenhua]

Thanks @ms-zhenhua - would you mind taking a look at the comment I left on the container_id suggestion?

Hi @stephybun - Thank you for your clarification. I have updated this part. Kindly take another review.

[stephybun]

Two more comments but other than that this should be good to go!

[ms-zhenhua]

Hi @stephybun, thank you for your review. I have resolved these 2 comments. Kindly take another review.

[stephybun]

Thanks @ms-zhenhua LGTM 🏖️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.