Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: updating to v0.20230427.1112058 of github.com/hashicorp/go-azure-sdk #21583

Merged
merged 9 commits into from
Apr 27, 2023
Merged

dependencies: updating to v0.20230427.1112058 of github.com/hashicorp/go-azure-sdk #21583

merged 9 commits into from
Apr 27, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Apr 27, 2023 •
edited
Loading

This PR:

* authentication: using the token expiry time from the Azure CLI when using that to authenticate (https://github.com/hashicorp/go-azure-sdk/pull/415)
* dependencies: updates to `v0.20230427.1112058` of `github.com/hashicorp/go-azure-sdk` [GH-21583]
* `databoxedge`: updating to API Version `2022-03-01` to workaround https://github.com/Azure/azure-rest-api-specs/issues/23749 [GH-21583]

stephybun
stephybun approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Apr 27, 2023 •
edited
Loading

Needed to update DataBox Edge to the latest API Version to workaround an API issue:

 $ TF_ACC=1 go test -v ./internal/services/databoxedge -run=TestAccDataboxEdgeDevice_basic -timeout=60m
=== RUN   TestAccDataboxEdgeDevice_basic
=== PAUSE TestAccDataboxEdgeDevice_basic
=== CONT  TestAccDataboxEdgeDevice_basic
--- PASS: TestAccDataboxEdgeDevice_basic (211.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/databoxedge	212.464s

DataBoxEdge looks ✅
DataBricks looks ✅
PostgreSQL Flexible Server looks ✅

@tombuildsstuff tombuildsstuff mentioned this pull request Apr 27, 2023
Closed
1 task
jackofallops
jackofallops approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 72f27ae into main Apr 27, 2023
@jackofallops jackofallops deleted the dependencies/go-azure-sdk branch April 27, 2023 14:35
@github-actions github-actions bot added this to the v3.54.0 milestone Apr 27, 2023
jackofallops added a commit that referenced this pull request Apr 27, 2023
@jackofallops
Update CHANGELOG.md for #21583
8bafb2d
@manicminer manicminer mentioned this pull request Apr 27, 2023
Closed
1 task
@manicminer manicminer linked an issue Apr 27, 2023 that may be closed by this pull request
auxiliary_tenant_ids LinkedAuthorizationFailed errors after azurerm v3.43.0 #21346
Closed
1 task
manicminer added a commit that referenced this pull request Apr 27, 2023
@manicminer
Additional changelog notice for #21583
6fea6ab
xiaxyi pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Apr 28, 2023
@tombuildsstuff @stephybun @xiaxyi
dependencies: updating to v0.20230427.1112058 of `github.com/hashic…
d22efa4 
…orp/go-azure-sdk` (hashicorp#21583)

Co-authored-by: Steph <steph@hashicorp.com>
xiaxyi pushed a commit to xiaxyi/terraform-provider-azurerm that referenced this pull request Apr 28, 2023
@manicminer @xiaxyi
Additional changelog notice for hashicorp#21583
ce928e9
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@jackofallops jackofallops jackofallops approved these changes

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
dependencies service/data-protection service/databox-edge service/digital-twins service/postgresql service/virtual-desktops size/XL
Projects
None yet
Milestone
v3.54.0
Development

Successfully merging this pull request may close these issues.

auxiliary_tenant_ids LinkedAuthorizationFailed errors after azurerm v3.43.0
4 participants
@tombuildsstuff @manicminer @jackofallops @stephybun