Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_machine_learning_workspace - Fix Key Vault ID validation error #21684

Merged
merged 1 commit into from
May 8, 2023

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented May 6, 2023

  1. Fix ID validation error. The Key Vault ID returned by service is case insensitive.
  2. Fix AccTest failure.
=== RUN   TestAccMachineLearningWorkspace_requiresImport
=== PAUSE TestAccMachineLearningWorkspace_requiresImport
=== CONT  TestAccMachineLearningWorkspace_requiresImport
--- PASS: TestAccMachineLearningWorkspace_requiresImport (689.67s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       706.525s

=== RUN   TestAccMachineLearningWorkspaceDataSource_basic
=== PAUSE TestAccMachineLearningWorkspaceDataSource_basic
=== CONT  TestAccMachineLearningWorkspaceDataSource_basic
--- PASS: TestAccMachineLearningWorkspaceDataSource_basic (1993.35s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       2023.477s

=== RUN   TestAccMachineLearningWorkspace_complete
=== PAUSE TestAccMachineLearningWorkspace_complete
=== RUN   TestAccMachineLearningWorkspace_completeUpdate
=== PAUSE TestAccMachineLearningWorkspace_completeUpdate
=== CONT  TestAccMachineLearningWorkspace_complete
=== CONT  TestAccMachineLearningWorkspace_completeUpdate
--- PASS: TestAccMachineLearningWorkspace_complete (1886.00s)
--- PASS: TestAccMachineLearningWorkspace_completeUpdate (2078.67s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       2084.885s

@xuzhang3 xuzhang3 changed the title * fix key vault ID validation error azurerm_machine_learning_workspace - Fix Key Vault ID validation error May 6, 2023
@stephybun stephybun added the bug label May 8, 2023
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 LGTM 🍕

@stephybun stephybun merged commit 35f2710 into hashicorp:main May 8, 2023
12 checks passed
@github-actions github-actions bot added this to the v3.56.0 milestone May 8, 2023
stephybun added a commit that referenced this pull request May 8, 2023
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request May 8, 2023
* fix acc tests

Co-authored-by: xuzhang3 <Zhangxu894765>
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request May 8, 2023
* fix acc tests

Co-authored-by: xuzhang3 <Zhangxu894765>
ziyeqf pushed a commit to ziyeqf/terraform-provider-azurerm that referenced this pull request May 8, 2023
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants