provider: adding a cache around the Resource Provider Registration

[tombuildsstuff]

This PR supersedes #20050 and hashicorp/go-azure-helpers#158 and introduces a cache for the list of Resource Providers cached during provider startup.

As mentioned in #20050, the providers API can take 6-8s to respond - as such there's performance benefits to caching this, in theory. Whilst that PR looks reasonable, we actually need to remove this logic from hashicorp/go-azure-helpers (since it can't be migrated across to using hashicorp/go-azure-sdk without adding a circular reference - and this is also specific to Resource Manager API's).

However since Terraform relaunches the provider binary multiple times - that is during a terraform apply the binary will be launched once to compute the plan and then another time post-plan confirmation - meaning that the providers API will still be called multiple times per terraform run, however this'll be limited to one time per provider binary launch.

As such this PR:

1. Updates the Resource Provider Registration SDK to using hashicorp/go-azure-sdk (meaning we can remove this logic from hashicorp/go-azure-helpers).
2. Updates the API Version used to register Resource Providers to 2022-09-01.
3. Adds Custom Pollers to ensure the Resource Providers are fully registered at provider launch (by polling on the registrationState field).

Supersedes #20050
Supersedes hashicorp/go-azure-helpers#158

* provider: Resource Provider Registration now uses API Version [GH-21695]
* provider: fixing a bug where we would invoke but not poll for the Registration State during automatic Resource Provider Registration [GH-21695]

[tombuildsstuff]

@manicminer @jackofallops I've moved this logic fully into the Provider, but part of me's wondering if this belongs within `hashicorp/go-azure-sdk - WDYT?

[jackofallops]

@manicminer @jackofallops I've moved this logic fully into the Provider, but part of me's wondering if this belongs within `hashicorp/go-azure-sdk - WDYT?

Given the potential re-use in stack etc, possibly worth it in the longer term? But for now I think it's fine here?

[jackofallops]

Thanks @tombuildsstuff - LGTM 👍

[manicminer]

I agree this is probably best in the provider, and personally I'd likely just copy it into azurestack as needed and leave it at that.

[tombuildsstuff]

Tests look good 👍

[github-actions]

This functionality has been released in v3.56.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.