azurerm_kubernetes_cluster: Cycle node-pool if node_pool has node level relevant changes

[jkroepke]

Follow up from #20628

At the moment, only vm_size is support for the builtin cycle of node pool. I would also like to go this way, if os_disk_type has been changed from Managed to Ephemeral and back.

the os_disk_type, os_sku, os_disk_size_gb property of the default_node_pool is no longer ForceNew and can be resized by specifying temporary_name_for_rotation

[stephybun]

Thanks for this PR @jkroepke.

Aside from the comments left in-line we would also need to add a test for these. Once that's done we can take another look through this!

[jkroepke]

I hope, everything fits now.

[jkroepke]

@stephybun

% make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_cycleSystemNodePool' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_cycleSystemNodePool -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_cycleSystemNodePool
=== PAUSE TestAccKubernetesCluster_cycleSystemNodePool
=== CONT  TestAccKubernetesCluster_cycleSystemNodePool

--- PASS: TestAccKubernetesCluster_cycleSystemNodePool (2579.70s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    2582.301s

Looks fine on my site now. Mention that I add more properties here, since. See also #21762 which also request zones

[jkroepke]

Rebased

[jkroepke]

% make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_cycleSystemNodePool' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_cycleSystemNodePool -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_cycleSystemNodePool
=== PAUSE TestAccKubernetesCluster_cycleSystemNodePool
=== CONT  TestAccKubernetesCluster_cycleSystemNodePool
--- PASS: TestAccKubernetesCluster_cycleSystemNodePool (2756.32s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    2759.008s

[stephybun]

Thanks for extending this to additional properties @jkroepke. I left some comments in-line which need to be addresed - once those are resolved I will run the tests.

[jkroepke]

@stephybun Issues are resolved.

[stephybun]

Thanks for your effort on this @jkroepke. Hope you don't mind I pushed a minor update to the docs adding the Note from the review to the default_node_pool block.

The tests also look good so this is good to go! LGTM 🌵

[jkroepke]

Hope you don't mind I pushed a minor update to the docs adding the Note from the review to the default_node_pool block.

You are welcome. One less review cycle :)

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.