Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_autoscale_setting - upgrade API version from 2015-04-01 to 2022-10-01 #21887

Merged

Conversation

teowa
Copy link
Contributor

@teowa teowa commented May 23, 2023

No description provided.

@catriona-m
Copy link
Member

Thanks for this @teowa - looks like we have a test failure here:

------- Stdout: -------
=== RUN   TestAccMonitorAutoScaleSetting_multipleRulesDimensions
=== PAUSE TestAccMonitorAutoScaleSetting_multipleRulesDimensions
=== CONT  TestAccMonitorAutoScaleSetting_multipleRulesDimensions
testcase.go:110: Step 7/8 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_monitor_autoscale_setting.test will be updated in-place
~ resource "azurerm_monitor_autoscale_setting" "test" {
id                  = "/subscriptions/*******/resourceGroups/acctestRG-230523062216942589/providers/Microsoft.Insights/autoScaleSettings/acctestautoscale-230523062216942589"
name                = "acctestautoscale-230523062216942589"
tags                = {}
# (4 unchanged attributes hidden)
~ profile {
name = "metricRules"
~ rule {
~ metric_trigger {
# (10 unchanged attributes hidden)
- dimensions {
- name     = "AppName2" -> null
- operator = "NotEquals" -> null
- values   = [
- "App2",
] -> null
}
- dimensions {
- name     = "Deployment" -> null
- operator = "Equals" -> null
- values   = [
- "default",
] -> null
}
}
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccMonitorAutoScaleSetting_multipleRulesDimensions (319.92s)
FAIL

…m into autoscale_setting_upgrade_to_2022-10-01
@teowa
Copy link
Contributor Author

teowa commented May 24, 2023

image

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM!

@catriona-m catriona-m merged commit bd452c0 into hashicorp:main May 24, 2023
13 checks passed
@github-actions github-actions bot added this to the v3.58.0 milestone May 24, 2023
catriona-m added a commit that referenced this pull request May 24, 2023
@github-actions
Copy link

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants