azurerm_postgresql_flexible_server - fix issue updating storage_mb and backup_retention_days together

[myc2h6o]

Caught in TestAccPostgresqlFlexibleServer_completeUpdate
when storage_mb and backup_retention_days are updated at a single request, backup_retention_days is not updated.

Similar to the logic here

terraform-provider-azurerm/internal/services/mysql/mysql_flexible_server_resource.go

Lines 690 to 697 in fd2b791

	if d.HasChange("storage") && !d.Get("storage.0.auto_grow_enabled").(bool) {
	parameters := servers.ServerForUpdate{
	Properties: &servers.ServerPropertiesForUpdate{
	Storage: expandArmServerStorage(d.Get("storage").([]interface{})),
	},
	}
	if err := client.UpdateThenPoll(ctx, *id, parameters); err != nil {

[myc2h6o]

Test result

[mbfrahry]

Is this a bug in the api that a value isn't updated if another value is also being updated? We should open an issue on the rest-api-specs and link that here

[myc2h6o]

@mbfrahry thanks for reviewing the change! I've found an existing issue in the spec repo Azure/azure-rest-api-specs#22867 and linked it to the comment

[mbfrahry]

LGTM! Thanks for finding and linking that!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.