Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server - Fix issue where minimum_tls_version is being returned as None instead of Disabled #22067

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jun 7, 2023

Test case TestAccMsSqlServer_minimumTLSVersionDisabled failed with the error "minimum_tls_version cannot be removed once set, please set a valid value for this property." This is caused by the API returns the value of minimum_tls_version is None when the setting value of minimum_tls_version in tf config is disabled . Previously, the API would not return any value in this case. I assume that this is an API breaking change. An API issue has been filed to track it. Meanwhile, submitted this PR to fix the issue.

Test results:
image

@github-actions github-actions bot added service/mssql Microsoft SQL Server size/XS labels Jun 7, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was working up until last month and looks like a breaking api change. Can we open an issue on rest-api-specs and leave a comment here about it?

@sinbai
Copy link
Contributor Author

sinbai commented Jun 8, 2023

This was working up until last month and looks like a breaking api change. Can we open an issue on rest-api-specs and leave a comment here about it?

@mbfrahry thanks for your time. I have submitted an API issue here.

@mbfrahry
Copy link
Member

mbfrahry commented Jun 8, 2023

Fixes #21882

@mbfrahry mbfrahry changed the title azurerm_mssql_server - Fix acc test failure for test case TestAccMsSqlServer_minimumTLSVersionDisabled azurerm_mssql_server - Fix issue where minimum_tls_version is being returned as None instead of Disabled Jun 8, 2023
@mbfrahry mbfrahry added this to the v3.60.0 milestone Jun 8, 2023
@mbfrahry mbfrahry merged commit ce09370 into hashicorp:main Jun 8, 2023
12 checks passed
mbfrahry added a commit that referenced this pull request Jun 8, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mssql Microsoft SQL Server size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants