New Data Source: azurerm_automation_variables

[oWretch]

Create a data resource for fetching all the variables in an automation account. Modelled after azurerm_key_vault_secrets.

--- PASS: TestAccDataSourceAzureRMAutomationVariables_basic (143.66s)

[stephybun]

Thanks for this PR @oWretch.

I have a few suggestions and questions which need looking over. Once those are resolved I can proceed with my review.

I also wanted to call out that all new resources and data sources should be typed (this was copied from an untyped data source within the provider). We have some contributor docs on what that means here, there are also guides in that folder on how to write typed resources/data sources.

For the moment this is fine, but just something to keep in mind for any future resources/data sources you choose to contribute here - having them typed would help us out a lot!

[stephybun]

What variable type is this? I don't see a resource for this variable type - so in what cases would this be populated?

[oWretch]

Microsoft offer a null type variable in an automation account. Currently there is no TF resource for it, but it can be populated from the Azure portal. I added to this data source to try and get all the different variables that might be created available.

If we want consistency, I could add a resource for the null variable type so we can create them in TF.

[oWretch]

Updated based on comments.

=== RUN   TestAccDataSourceAzureRMAutomationVariables_basic
=== PAUSE TestAccDataSourceAzureRMAutomationVariables_basic
=== CONT  TestAccDataSourceAzureRMAutomationVariables_basic
--- PASS: TestAccDataSourceAzureRMAutomationVariables_basic (147.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/automation	148.565s

I'll try to update to be a typed source…

[oWretch]

@stephybun I've converted to a typed data source now too

=== RUN   TestAccDataSourceAzureRMAutomationVariables_basic
=== PAUSE TestAccDataSourceAzureRMAutomationVariables_basic
=== CONT  TestAccDataSourceAzureRMAutomationVariables_basic
--- PASS: TestAccDataSourceAzureRMAutomationVariables_basic (147.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/automation	148.590s

[stephybun]

Thanks for converting this to a typed resource @oWretch! LGTM 🦆

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.