Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_arc_private_link_scope #22314

Merged
merged 15 commits into from
Jul 3, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Jun 29, 2023

New Resource: azurerm_arc_private_link_scope

Swagger Link:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json

Tesing Evidence:

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___TestAccArcPrivateLinkScope_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/hybridcompute #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___TestAccArcPrivateLinkScope_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccArcPrivateLinkScope_basic\E$ #gosetup
=== RUN   TestAccArcPrivateLinkScope_basic
=== PAUSE TestAccArcPrivateLinkScope_basic
=== CONT  TestAccArcPrivateLinkScope_basic
--- PASS: TestAccArcPrivateLinkScope_basic (170.70s)
PASS

Process finished with the exit code 0
GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___TestAccArcPrivateLinkScope_update_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/hybridcompute #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___TestAccArcPrivateLinkScope_update_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_hybridcompute.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccArcPrivateLinkScope_update\E$ #gosetup
=== RUN   TestAccArcPrivateLinkScope_update
=== PAUSE TestAccArcPrivateLinkScope_update
=== CONT  TestAccArcPrivateLinkScope_update
--- PASS: TestAccArcPrivateLinkScope_update (245.81s)
PASS


Process finished with the exit code 0

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun, a couple of comments that need to be fixed up but otherwise this looks fine.

liuwuliuyun and others added 2 commits June 30, 2023 09:54
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
liuwuliuyun and others added 8 commits June 30, 2023 09:54
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
…e.go

Co-authored-by: stephybun <steph@hashicorp.com>
…e_test.go

Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
@liuwuliuyun
Copy link
Contributor Author

Generating script.
Script contents:
TF_ACC=1 go test -parallel 10 -v ./internal/services/hybridcompute -run=TestAccArcPrivateLinkScope_ -timeout '720m' -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
========================== Starting Command Output ===========================
/usr/bin/bash /mnt/vss/_work/_temp/e5bb1e15-e9b4-45f8-bde0-55f9fe7d9de6.sh
=== RUN   TestAccArcPrivateLinkScope_basic
=== PAUSE TestAccArcPrivateLinkScope_basic
=== RUN   TestAccArcPrivateLinkScope_complete
=== PAUSE TestAccArcPrivateLinkScope_complete
=== RUN   TestAccArcPrivateLinkScope_update
=== PAUSE TestAccArcPrivateLinkScope_update
=== RUN   TestAccArcPrivateLinkScope_requireImport
=== PAUSE TestAccArcPrivateLinkScope_requireImport
=== CONT  TestAccArcPrivateLinkScope_basic
=== CONT  TestAccArcPrivateLinkScope_update
=== CONT  TestAccArcPrivateLinkScope_complete
=== CONT  TestAccArcPrivateLinkScope_requireImport
--- PASS: TestAccArcPrivateLinkScope_complete (85.63s)
--- PASS: TestAccArcPrivateLinkScope_requireImport (118.00s)
--- PASS: TestAccArcPrivateLinkScope_basic (127.20s)
--- PASS: TestAccArcPrivateLinkScope_update (152.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/hybridcompute	152.954s
Finishing: Run test in parallel

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 👍

@stephybun stephybun merged commit f9ce7b2 into hashicorp:main Jul 3, 2023
15 checks passed
@github-actions github-actions bot added this to the v3.64.0 milestone Jul 3, 2023
stephybun added a commit that referenced this pull request Jul 3, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants