-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_arc_private_link_scope
#22314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liuwuliuyun, a couple of comments that need to be fixed up but otherwise this looks fine.
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource.go
Outdated
Show resolved
Hide resolved
internal/services/hybridcompute/arc_private_link_scope_resource_test.go
Outdated
Show resolved
Hide resolved
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e.go Co-authored-by: stephybun <steph@hashicorp.com>
…e_test.go Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liuwuliuyun LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
New Resource:
azurerm_arc_private_link_scope
Swagger Link:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2022-11-10/privateLinkScopes.json
Tesing Evidence: