azurerm_linux_virtual_machine azurerm_windows_virtual_machine - support bypass_platform_safety_checks_on_user_schedule_enabled and reboot_setting
#22349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport `bypass_platform_safety_checks_on_user_schedule_enabled` and `reboot_setting`
|
Test result |
stephybun
requested changes
Jul 13, 2023
stephybun
requested changes
Jul 27, 2023
Comment on lines
899
to
900
| if v := patchSettings.AutomaticByPlatformSettings.BypassPlatformSafetyChecksOnUserSchedule; v != nil { | ||
| bypassPlatformSafetyChecksOnUserScheduleEnabled = pointer.From(v) |
There was a problem hiding this comment.
pointer.From contains nil checking so this can be condensed down to
Suggested change
| if v := patchSettings.AutomaticByPlatformSettings.BypassPlatformSafetyChecksOnUserSchedule; v != nil { | |
| bypassPlatformSafetyChecksOnUserScheduleEnabled = pointer.From(v) | |
| bypassPlatformSafetyChecksOnUserScheduleEnabled = pointer.From(v) |
Comment on lines
902
to
904
| if v := patchSettings.AutomaticByPlatformSettings.RebootSetting; v != "" { | ||
| rebootSetting = string(v) | ||
| } |
There was a problem hiding this comment.
Can condense this as well
Suggested change
| if v := patchSettings.AutomaticByPlatformSettings.RebootSetting; v != "" { | |
| rebootSetting = string(v) | |
| } | |
| rebootSetting = string(v) |
| @@ -126,6 +126,10 @@ The following arguments are supported: | |||
|
|
|||
| * `boot_diagnostics` - (Optional) A `boot_diagnostics` block as defined below. | |||
|
|
|||
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patch when user schedule is associated to the VM. Defaults to `false`. | |||
There was a problem hiding this comment.
Suggested change
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patch when user schedule is associated to the VM. Defaults to `false`. | |
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patching when a user schedule is associated with the VM. Defaults to `false`. |
| @@ -182,6 +186,10 @@ The following arguments are supported: | |||
|
|
|||
| * `proximity_placement_group_id` - (Optional) The ID of the Proximity Placement Group which the Virtual Machine should be assigned to. | |||
|
|
|||
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patch. Possible values are `Always`, `IfRequired` and `Never`. | |||
There was a problem hiding this comment.
Suggested change
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patch. Possible values are `Always`, `IfRequired` and `Never`. | |
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patching. Possible values are `Always`, `IfRequired` and `Never`. |
| @@ -119,6 +119,10 @@ The following arguments are supported: | |||
|
|
|||
| * `boot_diagnostics` - (Optional) A `boot_diagnostics` block as defined below. | |||
|
|
|||
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patch when user schedule is associated to the VM. Defaults to `false`. | |||
There was a problem hiding this comment.
Suggested change
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patch when user schedule is associated to the VM. Defaults to `false`. | |
| * `bypass_platform_safety_checks_on_user_schedule_enabled` - (Optional) Specifies whether to skip platform scheduled patching when a user schedule is associated with the VM. Defaults to `false`. |
| @@ -177,6 +181,10 @@ The following arguments are supported: | |||
|
|
|||
| * `proximity_placement_group_id` - (Optional) The ID of the Proximity Placement Group which the Virtual Machine should be assigned to. | |||
|
|
|||
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patch. Possible values are `Always`, `IfRequired` and `Never`. | |||
There was a problem hiding this comment.
Suggested change
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patch. Possible values are `Always`, `IfRequired` and `Never`. | |
| * `reboot_setting` - (Optional) Specifies the reboot setting for platform scheduled patching. Possible values are `Always`, `IfRequired` and `Never`. |
|
@stephybun thanks for reviewing the change! I've updated the code and the doc according to your comments, please take a look. |
stephybun
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #21690
Document: https://learn.microsoft.com/azure/update-center/prerequsite-for-schedule-patching?tabs=new-prereq-rest-api%2Cauto-portal