New data source azurerm_communication_service
#22426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myc2h6o
force-pushed
the
communication_service_data
branch
from
dc53f7a
to
58f3374
Compare
|
test result |
tombuildsstuff
requested changes
Jul 10, 2023
There was a problem hiding this comment.
hey @myc2h6o
Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up then this should otherwise be good to go 👍
Thanks!
|
|
||
| keysResp, err := client.ListKeys(ctx, id) | ||
| if err != nil { | ||
| return fmt.Errorf("listing keys for %s: %+v", id, err) |
There was a problem hiding this comment.
data sources should gracefully handle having limited permissions, so we shouldn't raise this error when there's a permissions error (presumably a 401?)
Comment on lines
124
to
138
| if model.PrimaryConnectionString != nil { | ||
| state.PrimaryConnectionString = *model.PrimaryConnectionString | ||
| } | ||
|
|
||
| if model.PrimaryKey != nil { | ||
| state.PrimaryKey = *model.PrimaryKey | ||
| } | ||
|
|
||
| if model.SecondaryConnectionString != nil { | ||
| state.SecondaryConnectionString = *model.SecondaryConnectionString | ||
| } | ||
|
|
||
| if model.SecondaryKey != nil { | ||
| state.SecondaryKey = *model.SecondaryKey | ||
| } |
There was a problem hiding this comment.
FWIW we can reduce this to:
Suggested change
| if model.PrimaryConnectionString != nil { | |
| state.PrimaryConnectionString = *model.PrimaryConnectionString | |
| } | |
| if model.PrimaryKey != nil { | |
| state.PrimaryKey = *model.PrimaryKey | |
| } | |
| if model.SecondaryConnectionString != nil { | |
| state.SecondaryConnectionString = *model.SecondaryConnectionString | |
| } | |
| if model.SecondaryKey != nil { | |
| state.SecondaryKey = *model.SecondaryKey | |
| } | |
| state.PrimaryConnectionString = pointer.From(model.PrimaryConnectionString) | |
| state.PrimaryKey = pointer.From(model.PrimaryKey) | |
| state.SecondaryConnectionString = pointer.From(model.SecondaryConnectionString) | |
| state.SecondaryKey = pointer.From(model.SecondaryKey) |
|
@tombuildsstuff thanks for reviewing! I've updated the code to use |
|
updated test result |
tombuildsstuff
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #21736