Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ExpressRoute virtual network gateway types #2260

Merged
merged 1 commit into from Nov 7, 2018

Conversation

tasador
Copy link
Contributor

@tasador tasador commented Nov 7, 2018

New ExpressRoute virtual network gateways are available: ErGw1AZ, ErGw2AZ, ErGw3AZ:

https://azure.microsoft.com/en-us/updates/zone-redundant-vpn-and-expressroute-virtual-network-gateways-generally-available/

This commit just fixes validation to accept these new types.

@ghost ghost added the size/XS label Nov 7, 2018
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @tasador 👍

@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 7, 2018
@tombuildsstuff tombuildsstuff merged commit 1cd5ba2 into hashicorp:master Nov 7, 2018
tombuildsstuff added a commit that referenced this pull request Nov 7, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants