New resources azurerm_mssql_virtual_machine_group and azurerm_mssql_virtual_machine_availability_group_listener

[myc2h6o]

Add support for SQL Virtual Machine Group and SQL Virtual Machine Availability Group Listener. This adds the ability to configure Always-On SQL Availability Group for SQL VMs.
Document
Swagger

[stephybun]

Thanks for this PR @myc2h6o. I've left some comments in-line that need to be fixed up but once that's done we can take another look through.

[stephybun]

I only see this referenced once and the schema is flat so can we just in-line this here instead of defining it as a func elsewhere?

[myc2h6o]

@stephybun thanks for reviewing the pr! I have updated it according to your comments, please take a look.

[stephybun]

Thanks for addressing those comments @myc2h6o. Once comment was missed it seems and there's one typo in the docs. I've pointed them out in-line. Once they're resolved this should be good to go!

[stephybun]

Since we can only supply one of these and they're required we can flatten these.

Suggested change

	"private_ip_address": {
	Type: pluginsdk.TypeList,
	Required: true,
	ForceNew: true,
	MaxItems: 1,
	Elem: &pluginsdk.Resource{
	Schema: map[string]*pluginsdk.Schema{
	"ip_address": {
	Type: pluginsdk.TypeString,
	Required: true,
	ForceNew: true,
	ValidateFunc: validation.IsIPAddress,
	},
	"subnet_id": {
	Type: pluginsdk.TypeString,
	Required: true,
	ForceNew: true,
	ValidateFunc: networkValidate.SubnetID,
	},
	},
	},
	},
	"private_ip_address": {
	Type: pluginsdk.TypeString,
	Required: true,
	ForceNew: true,
	ValidateFunc: validation.IsIPAddress,
	},
	"subnet_id": {
	Type: pluginsdk.TypeString,
	Required: true,
	ForceNew: true,
	ValidateFunc: networkValidate.SubnetID,
	},

[stephybun]

Same here

[stephybun]

Suggested change

	* `commit` - (Required) T replica commit mode for the availability group. Possible values are `Synchronous_Commit` and `Asynchronous_Commit`. Changing this forces a new resource to be created.
	* `commit` - (Required) The replica commit mode for the availability group. Possible values are `Synchronous_Commit` and `Asynchronous_Commit`. Changing this forces a new resource to be created.

[myc2h6o]

@stephybun thanks, I've further flattened the private_ip_address and fixed the doc according to your comments

[stephybun]

Thanks @myc2h6o LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.