Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_stack_hci_cluster - add a new property automanange_configuration_id #22857

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Aug 8, 2023

azurerm_stack_hci_cluster

  • add a new property automanange_configuration_id. This property is used to assign an automanage configuration profile to azure stack hci cluster.

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/automanage/resource-manager/Microsoft.Automanage/stable/2022-05-04/automanage.json

Testing evidence:

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun. Tests look good - I have one minor suggestion that will remove the else block but other than this this should be good to go!

Co-authored-by: stephybun <steph@hashicorp.com>
@liuwuliuyun
Copy link
Contributor Author

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 👍

@stephybun stephybun merged commit fd0d618 into hashicorp:main Aug 14, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.70.0 milestone Aug 14, 2023
stephybun added a commit that referenced this pull request Aug 15, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants