Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: porting network_service_tag, network_watcher, network_packet_capture over to hashicorp/go-azure-sdk #22873

Merged
merged 6 commits into from
Aug 9, 2023
Merged

refactor: porting network_service_tag, network_watcher, network_packet_capture over to hashicorp/go-azure-sdk #22873

merged 6 commits into from
Aug 9, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR ports the following resources within network to use hashicorp/go-azure-sdk:

  • Data Source: azurerm_network_service_tags
  • Data Source: azurerm_network_watcher
  • Resource: azurerm_network_packet_capture
  • Resource: azurerm_network_watcher_flow_log
  • Resource: azurerm_network_watcher
  • Resource: azurerm_virtual_machine_packet_capture
  • Resource: azurerm_virtual_machine_scale_set_packet_capture
  • Resource: azurerm_vpn_gateway_connection

@tombuildsstuff tombuildsstuff added this to the v3.69.0 milestone Aug 9, 2023
@tombuildsstuff tombuildsstuff marked this pull request as ready for review August 9, 2023 07:53
@tombuildsstuff tombuildsstuff requested a review from a team August 9, 2023 07:53
stephybun
stephybun approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI is fixed up and tests pass LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the refactor/network-to-go-azure-sdk-2 branch from 2053b57 to a373f7b Compare August 9, 2023 08:40
@tombuildsstuff tombuildsstuff merged commit 175f66f into main Aug 9, 2023
20 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/network-to-go-azure-sdk-2 branch August 9, 2023 15:07
tombuildsstuff added a commit that referenced this pull request Aug 9, 2023
@tombuildsstuff
updating to include #22873
8b1d29d
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
refactor service/network size/XL waiting-response
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tombuildsstuff @stephybun