`azurerm_network_interface` - Support `auxiliary_mode`, `auxiliary_sku` #22979

ms-zhenhua · 2023-08-16T10:15:45Z

Swagger Link

https://github.com/Azure/azure-rest-api-specs/blob/1df6d6f671dc5059016fbc2c0a624e01f0b2972c/specification/network/resource-manager/Microsoft.Network/stable/2023-02-01/networkInterface.json#L1212

https://github.com/Azure/azure-rest-api-specs/blob/1df6d6f671dc5059016fbc2c0a624e01f0b2972c/specification/network/resource-manager/Microsoft.Network/stable/2023-02-01/networkInterface.json#L1226C10-L1226C22

Test Result

=== RUN TestAccNetworkInterface_auxiliary
=== PAUSE TestAccNetworkInterface_auxiliary
=== CONT TestAccNetworkInterface_auxiliary
--- PASS: TestAccNetworkInterface_auxiliary (360.05s)
PASS

tombuildsstuff

hi @ms-zhenhua

I've taken a look through and left some comments inline, however many of the comments I've raised in this PR have been raised in previous PR's (for example the None issue, which can be found here) - as such would you mind fixing these up and paying particular attention to the None issue going forward?

Thanks!

tombuildsstuff · 2023-08-16T10:36:45Z

internal/services/network/network_interface_resource.go

+					string(networkinterfaces.NetworkInterfaceAuxiliaryModeNone),
+				}, false),
+				Default:      string(networkinterfaces.NetworkInterfaceAuxiliaryModeNone),


we don't need to expose None here, since this is already available in the provider by omitting the value for this field (null) - so can we remove this:

Suggested change

string(networkinterfaces.NetworkInterfaceAuxiliaryModeNone),

}, false),

Default: string(networkinterfaces.NetworkInterfaceAuxiliaryModeNone),

}, false),

code updated

tombuildsstuff · 2023-08-16T10:36:56Z

internal/services/network/network_interface_resource.go

+					string(networkinterfaces.NetworkInterfaceAuxiliarySkuNone),
+				}, false),
+				Default:      string(networkinterfaces.NetworkInterfaceAuxiliarySkuNone),


(same here)

Suggested change

string(networkinterfaces.NetworkInterfaceAuxiliarySkuNone),

}, false),

Default: string(networkinterfaces.NetworkInterfaceAuxiliarySkuNone),

}, false),

code updated

tombuildsstuff · 2023-08-16T10:37:27Z

internal/services/network/network_interface_resource.go

+			d.Set("auxiliary_mode", pointer.From(props.AuxiliaryMode))
+			d.Set("auxiliary_sku", pointer.From(props.AuxiliarySku))


these'll both need to be normalized on the way back, since this won't be returned for older NICs - therefore None ("") should be the default value, and we should only be overriding that if the value is != nil && !strings.EqualFold(*value, "None"))

code updated

tombuildsstuff · 2023-08-16T10:39:27Z

internal/services/network/network_interface_resource_test.go

+	if mode != "" {
+		mode = fmt.Sprintf(`auxiliary_mode = "%s"`, mode)
+	}
+
+	if sku != "" {
+		sku = fmt.Sprintf(`auxiliary_sku = "%s"`, sku)
+	}


it'd be easier/clearer to use separate test templates here - so can we update this to be one test template per type?

In addition, since these two fields must be specified together, this conditional logic would lead to an invalid configuration - another reason to use a separate test template here to make that clearer

code updated

tombuildsstuff · 2023-08-16T10:39:45Z

website/docs/r/network_interface.html.markdown

+
+-> **Note:** This field requires the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.
+
+* `auxiliary_sku` - (Optional) The Auxiliary SKU of the Network Interface. Possible values are `A1`, `A2`, `A4`, `A8` and `None`. Defaults to `None`.


firstly: does this require the preview feature too?

secondly:

Suggested change

* `auxiliary_sku` - (Optional) The Auxiliary SKU of the Network Interface. Possible values are `A1`, `A2`, `A4`, `A8` and `None`. Defaults to `None`.

* `auxiliary_sku` - (Optional) The Auxiliary SKU of the Network Interface. Possible values are `A1`, `A2`, `A4`, `A8`.

thirdly: what does this do? this description isn't clear/descriptive?

firstly: Yes, I updated the doc for both of them
secondly: doc updated.
thirdly: It is used for enabling Accelerated Connections to improve networking performance. I have updated the doc.

tombuildsstuff · 2023-08-16T10:43:29Z

website/docs/r/network_interface.html.markdown

@@ -60,6 +60,12 @@ The following arguments are supported:

 ---

+* `auxiliary_mode` - (Optional) The Auxiliary mode of the Network Interface. Possible values are `AcceleratedConnections`, `Floating` and `None`. Defaults to `None`.


firstly:

Suggested change

* `auxiliary_mode` - (Optional) The Auxiliary mode of the Network Interface. Possible values are `AcceleratedConnections`, `Floating` and `None`. Defaults to `None`.

* `auxiliary_mode` - (Optional) The Auxiliary mode of the Network Interface. Possible values are `AcceleratedConnections` and `Floating`.

secondly, what does this do? this description isn't clear/descriptive?

firstly: doc updated.
secondly: it is used for tuning the performance of network connections. I have updated the doc

ms-zhenhua · 2023-08-18T02:47:57Z

Hi @tombuildsstuff,

Thank you for your review. Sorry for not noticing the latest shema design. I will pay more attention in future. I have updated all comments and rerun the tests. Kindly take another review.

Thanks.

tombuildsstuff

hi @ms-zhenhua

Thanks for pushing those changes - I've taken a look through and left some comments inline, however would it be possible to explain the fastpathenabled tag?

Thanks!

tombuildsstuff · 2023-09-05T12:22:57Z

internal/services/network/network_interface_resource.go

+				ValidateFunc: validation.StringInSlice([]string{
+					string(networkinterfaces.NetworkInterfaceAuxiliarySkuAEight),
+					string(networkinterfaces.NetworkInterfaceAuxiliarySkuAFour),
+					string(networkinterfaces.NetworkInterfaceAuxiliarySkuAOne),
+					string(networkinterfaces.NetworkInterfaceAuxiliarySkuATwo),
+				}, false),


we can use:

Suggested change

ValidateFunc: validation.StringInSlice([]string{

string(networkinterfaces.NetworkInterfaceAuxiliarySkuAEight),

string(networkinterfaces.NetworkInterfaceAuxiliarySkuAFour),

string(networkinterfaces.NetworkInterfaceAuxiliarySkuAOne),

string(networkinterfaces.NetworkInterfaceAuxiliarySkuATwo),

}, false),

ValidateFunc: validation.StringInSlice(networkinterfaces.PossibleValuesForNetworkInterfaceAuxiliarySku(), false),

code updated. Thanks.

tombuildsstuff · 2023-09-05T12:23:13Z

internal/services/network/network_interface_resource.go

+					string(networkinterfaces.NetworkInterfaceAuxiliaryModeAcceleratedConnections),
+					string(networkinterfaces.NetworkInterfaceAuxiliaryModeFloating),


we can use possiblevaluesfor here fwiw

code updated. Thanks.

tombuildsstuff · 2023-09-05T12:29:32Z

internal/services/network/network_interface_resource.go

+	if d.HasChange("auxiliary_mode") {
+		if auxiliaryMode, hasAuxiliaryMode := d.GetOk("auxiliary_mode"); hasAuxiliaryMode {
+			update.Properties.AuxiliaryMode = pointer.To(networkinterfaces.NetworkInterfaceAuxiliaryMode(auxiliaryMode.(string)))
+		}
+	} else {
+		update.Properties.AuxiliaryMode = existing.Model.Properties.AuxiliaryMode
+	}


how do users unset this property?

If users remove this property from the .tf, the code will enter HasChange branch. Since hasAuxiliaryMode = false, update.Properties.AuxiliaryMode will not be assigned a value and use the default value nil, then Azure will unset this property.

internal/services/network/network_interface_resource.go

internal/services/network/network_interface_resource_test.go

ms-zhenhua · 2023-09-06T02:36:37Z

Hi @tombuildsstuff, thank you for your review. I have resolved the new comments and explained fastpathenabled tag. Could you kindly take another review? Thanks.

Test Result

=== RUN TestAccNetworkInterface_auxiliary
=== PAUSE TestAccNetworkInterface_auxiliary
=== CONT TestAccNetworkInterface_auxiliary
--- PASS: TestAccNetworkInterface_auxiliary (524.86s)
PASS

tombuildsstuff

Left a few comments around the documentation, as we should have a succinct explanation of what this does without requiring clicking through to another site, but if we can fix this up then it should otherwise be good to go 👍

tombuildsstuff · 2023-09-13T16:05:56Z

website/docs/r/network_interface.html.markdown

@@ -60,6 +60,12 @@ The following arguments are supported:

 ---

+* `auxiliary_mode` - (Optional) Specifies auxiliary mode for enabling [Accelerated Connections](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections) to improve networking performance. Possible values are `AcceleratedConnections` and `Floating`.


Can we make this description clearer to call out what this actually does / update the tone and style to match other fields too? We shouldn't need to link to a product page to explain what a value does.

Doc updated. Thanks.

tombuildsstuff · 2023-09-13T16:06:03Z

website/docs/r/network_interface.html.markdown

@@ -60,6 +60,12 @@ The following arguments are supported:

 ---

+* `auxiliary_mode` - (Optional) Specifies auxiliary mode for enabling [Accelerated Connections](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections) to improve networking performance. Possible values are `AcceleratedConnections` and `Floating`.
+
+* `auxiliary_sku` - (Optional) Specifies auxiliary SKU for tuning the performance of network connections. Possible values are `A1`, `A2`, `A4` and `A8`.


Doc updated. Thanks.

tombuildsstuff · 2023-09-13T16:07:10Z

website/docs/r/network_interface.html.markdown

+
+* `auxiliary_sku` - (Optional) Specifies auxiliary SKU for tuning the performance of network connections. Possible values are `A1`, `A2`, `A4` and `A8`.
+
+-> **Note:** `auxiliary_mode` and `auxiliary_sku` require the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.


The Preview note should be listed under every preview field, and something along the lines of:

Suggested change

-> **Note:** `auxiliary_mode` and `auxiliary_sku` require the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.

-> **Note:** `auxiliary_mode` is in **Preview** and requires that the preview is enabled - [more information can be found in the Azure documentation](https://learn.microsoft.com/azure/networking/nva-accelerated-connections#prerequisites).

Doc updated. Thanks.

ms-zhenhua · 2023-09-14T02:53:28Z

Hi @tombuildsstuff, thank you for another review. I have updated the doc. Kindly help have a check. Thanks.

stephybun

Thanks @ms-zhenhua LGTM 💯

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.73.0" to "3.74.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.74.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.74.0
NOTES:

* `azurerm_synapse_sql_pool` - users that have imported `azurerm_synapse_sql_pool` resources that were created outside of Terraform using an `LRS` storage account type will need to use `ignore_changes` to avoid the resource from being destroyed and recreated.

FEATURES:

* **New Resource**: `azurerm_arc_resource_bridge_appliance` ([#23108](https://github.com/hashicorp/terraform-provider-azurerm/issues/23108))
* **New Resource**: `azurerm_data_factory_dataset_azure_sql_table` ([#23264](https://github.com/hashicorp/terraform-provider-azurerm/issues/23264))
* **New Resource**: `azurerm_function_app_connection` ([#23127](https://github.com/hashicorp/terraform-provider-azurerm/issues/23127))

ENHANCEMENTS:

* dependencies: updating to `v0.20230918.1115907` of `github.com/hashicorp/go-azure-sdk` ([#23337](https://github.com/hashicorp/terraform-provider-azurerm/issues/23337))
* dependencies: downgrading to `v1.12.5` of `github.com/rickb777/date` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `mysql`: updating to use API Version `2022-01-01` ([#23320](https://github.com/hashicorp/terraform-provider-azurerm/issues/23320))
* `azurerm_app_configuration` - support for the `replica` block ([#22452](https://github.com/hashicorp/terraform-provider-azurerm/issues/22452))
* `azurerm_bot_channel_directline` - support for `user_upload_enabled`, `endpoint_parameters_enabled`, and `storage_enabled` ([#23149](https://github.com/hashicorp/terraform-provider-azurerm/issues/23149))
* `azurerm_container_app` - support for scale rules ([#23294](https://github.com/hashicorp/terraform-provider-azurerm/issues/23294))
* `azurerm_container_app_environment` - support for zone redundancy ([#23313](https://github.com/hashicorp/terraform-provider-azurerm/issues/23313))
* `azurerm_container_group` - support for the `key_vault_user_identity_id` property for Customer Managed Keys ([#23332](https://github.com/hashicorp/terraform-provider-azurerm/issues/23332))
* `azurerm_cosmosdb_account` - support for MongoDB connection strings ([#23331](https://github.com/hashicorp/terraform-provider-azurerm/issues/23331))
* `azurerm_data_factory_dataset_delimited_text` - support for the `dynamic_file_system_enabled`, `dynamic_path_enabled`, and `dynamic_filename_enabled` properties ([#23261](https://github.com/hashicorp/terraform-provider-azurerm/issues/23261))
* `azurerm_data_factory_dataset_parquet` - support for the `azure_blob_fs_location` block ([#23261](https://github.com/hashicorp/terraform-provider-azurerm/issues/23261))
* `azurerm_monitor_diagnostic_setting` - validation to ensure either `category` or `category_group` are supplied in `enabled_log` and `log` blocks ([#23308](https://github.com/hashicorp/terraform-provider-azurerm/issues/23308))
* `azurerm_network_interface` - support for the `auxiliary_mode` and `auxiliary_sku` properties ([#22979](https://github.com/hashicorp/terraform-provider-azurerm/issues/22979))
* `azurerm_postgresql_flexible_server` - increased the maximum supported value for `storage_mb` ([#23277](https://github.com/hashicorp/terraform-provider-azurerm/issues/23277))
* `azurerm_shared_image_version` - support for the `replicated_region_deletion_enabled` and `target_region.exclude_from_latest_enabled` properties ([#23147](https://github.com/hashicorp/terraform-provider-azurerm/issues/23147))
* `azurerm_storage_account` - support for setting `domain_name` and `domain_guid` for `AADKERB` ([#22833](https://github.com/hashicorp/terraform-provider-azurerm/issues/22833))
* `azurerm_storage_account_customer_managed_key` - support for cross-tenant customer-managed keys with the `federated_identity_client_id`, and `key_vault_uri` properties ([#20356](https://github.com/hashicorp/terraform-provider-azurerm/issues/20356))
* `azurerm_web_application_firewall_policy` - support for the `rate_limit_duration`, `rate_limit_threshold`, `group_rate_limit_by`, and `request_body_inspect_limit_in_kb` properties ([#23239](https://github.com/hashicorp/terraform-provider-azurerm/issues/23239))

BUG FIXES:

* Data Source: `azurerm_container_app_environment`: fix `log_analytics_workspace_name` output to correct value ([#23298](https://github.com/hashicorp/terraform-provider-azurerm/issues/23298))
* `azurerm_api_management_api` - set the `service_url` property when importing the resource ([#23011](https://github.com/hashicorp/terraform-provider-azurerm/issues/23011))
* `azurerm_app_configuration` - prevent crash by nil checking the encryption configuration ([#23302](https://github.com/hashicorp/terraform-provider-azurerm/issues/23302))
* `azurerm_app_configuration_feature` - update `percentage_filter_value` to accept correct type of float ([#23263](https://github.com/hashicorp/terraform-provider-azurerm/issues/23263))
* `azurerm_container_app` - fix an issue with `commands` and `args` being overwritten when using multiple containers ([#23338](https://github.com/hashicorp/terraform-provider-azurerm/issues/23338))
* `azurerm_key_vault_certificate` - fix issue where certificates couldn't be recovered anymore ([#23204](https://github.com/hashicorp/terraform-provider-azurerm/issues/23204))
* `azurerm_key_vault_key` - the ForceNew when `expiration_date` is removed from the config file ([#23327](https://github.com/hashicorp/terraform-provider-azurerm/issues/23327))
* `azurerm_linux_function_app` - fix a bug in setting the storage settings when using Elastic Premium plans ([#21212](https://github.com/hashicorp/terraform-provider-azurerm/issues/21212))
* `azurerm_linux_web_app` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_linux_web_app` - fix crash in auto heal expansion ([#21328](https://github.com/hashicorp/terraform-provider-azurerm/issues/21328))
* `azurerm_linux_web_app_slot` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_linux_web_app_slot` - fix crash in auto heal expansion ([#21328](https://github.com/hashicorp/terraform-provider-azurerm/issues/21328))
* `azurerm_log_analytics_solution` - fix bug where the resource wasn't handling successful creation on subsequent applies ([#23312](https://github.com/hashicorp/terraform-provider-azurerm/issues/23312))
* `azurerm_management_group_subscription_association` - fix bug to correctly mark resource as gone if not found during read ([#23335](https://github.com/hashicorp/terraform-provider-azurerm/issues/23335))
* `azurerm_mssql_elasticpool` - remove check that prevents `license_type` from being set for certain skus ([#23262](https://github.com/hashicorp/terraform-provider-azurerm/issues/23262))
* `azurerm_servicebus_queue` - fixing an issue where `auto_delete_on_idle` couldn't be set to `P10675199DT2H48M5.4775807S` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `azurerm_servicebus_topic` - fixing an issue where `auto_delete_on_idle` couldn't be set to `P10675199DT2H48M5.4775807S` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `azurerm_storage_account` - prevent sending unsupported blob properties in payload for `Storage` account kind ([#23288](https://github.com/hashicorp/terraform-provider-azurerm/issues/23288))
* `azurerm_synapse_sql_pool` - expose `storage_account_type` ([#23217](https://github.com/hashicorp/terraform-provider-azurerm/issues/23217))
* `azurerm_windows_function_app` - fix a bug in setting the storage settings when using Elastic Premium plans ([#21212](https://github.com/hashicorp/terraform-provider-azurerm/issues/21212))
* `azurerm_windows_web_app` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_windows_web_app_slot` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))

DEPRECATIONS:

* `azurerm_application_gateway` - deprecate `Standard` and `WAF` skus ([#23310](https://github.com/hashicorp/terraform-provider-azurerm/issues/23310))
* `azurerm_bot_channel_web_chat` - deprecate `site_names` in favour of `site` block ([#23161](https://github.com/hashicorp/terraform-provider-azurerm/issues/23161))
* `azurerm_monitor_diagnostic_setting` - deprecate `retention_policy` in favour of `azurerm_storage_management_policy` ([#23260](https://github.com/hashicorp/terraform-provider-azurerm/issues/23260))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

add code

c5b5d13

github-actions bot added documentation service/network size/M labels Aug 16, 2023

tombuildsstuff requested changes Aug 16, 2023

View reviewed changes

github-actions bot added the waiting-response label Aug 16, 2023

resolve comments 0817

decfbcb

github-actions bot removed the waiting-response label Aug 17, 2023

resolve comments 0818

3d23252

ms-zhenhua requested a review from tombuildsstuff August 18, 2023 02:48

tombuildsstuff requested changes Sep 5, 2023

View reviewed changes

github-actions bot added the waiting-response label Sep 5, 2023

resolve comments 0906

401ed5a

github-actions bot removed the waiting-response label Sep 6, 2023

ms-zhenhua requested a review from tombuildsstuff September 6, 2023 02:36

github-actions bot added the waiting-response label Sep 12, 2023

tombuildsstuff requested changes Sep 13, 2023

View reviewed changes

resolve comments 0914

e553b9b

github-actions bot removed the waiting-response label Sep 14, 2023

ms-zhenhua requested a review from tombuildsstuff September 14, 2023 02:53

stephybun added the enhancement label Sep 18, 2023

stephybun approved these changes Sep 18, 2023

View reviewed changes

stephybun merged commit 685f277 into hashicorp:main Sep 18, 2023
26 checks passed

github-actions bot added this to the v3.74.0 milestone Sep 18, 2023

stephybun added a commit that referenced this pull request Sep 20, 2023

Update for #23011 #23277 #23260 #22833 #23288 #23147 #22979

e266595

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_network_interface` - Support `auxiliary_mode`, `auxiliary_sku` #22979

`azurerm_network_interface` - Support `auxiliary_mode`, `auxiliary_sku` #22979

ms-zhenhua commented Aug 16, 2023 •

edited

tombuildsstuff left a comment

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

tombuildsstuff Aug 16, 2023

ms-zhenhua Aug 18, 2023

ms-zhenhua commented Aug 18, 2023

tombuildsstuff left a comment

tombuildsstuff Sep 5, 2023

ms-zhenhua Sep 6, 2023

tombuildsstuff Sep 5, 2023

ms-zhenhua Sep 6, 2023

tombuildsstuff Sep 5, 2023

ms-zhenhua Sep 6, 2023 •

edited

ms-zhenhua commented Sep 6, 2023

tombuildsstuff left a comment

tombuildsstuff Sep 13, 2023

ms-zhenhua Sep 14, 2023

tombuildsstuff Sep 13, 2023

ms-zhenhua Sep 14, 2023

tombuildsstuff Sep 13, 2023

ms-zhenhua Sep 14, 2023

ms-zhenhua commented Sep 14, 2023

stephybun left a comment

		d.Set("auxiliary_mode", pointer.From(props.AuxiliaryMode))
		d.Set("auxiliary_sku", pointer.From(props.AuxiliarySku))


		-> Note: This field requires the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.

		* `auxiliary_sku` - (Optional) The Auxiliary SKU of the Network Interface. Possible values are `A1`, `A2`, `A4`, `A8` and `None`. Defaults to `None`.

		@@ -60,6 +60,12 @@ The following arguments are supported:

		---

		* `auxiliary_mode` - (Optional) The Auxiliary mode of the Network Interface. Possible values are `AcceleratedConnections`, `Floating` and `None`. Defaults to `None`.

		string(networkinterfaces.NetworkInterfaceAuxiliaryModeAcceleratedConnections),
		string(networkinterfaces.NetworkInterfaceAuxiliaryModeFloating),

		@@ -60,6 +60,12 @@ The following arguments are supported:

		---

		* `auxiliary_mode` - (Optional) Specifies auxiliary mode for enabling [Accelerated Connections](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections) to improve networking performance. Possible values are `AcceleratedConnections` and `Floating`.


		* `auxiliary_sku` - (Optional) Specifies auxiliary SKU for tuning the performance of network connections. Possible values are `A1`, `A2`, `A4` and `A8`.

		-> Note: `auxiliary_mode` and `auxiliary_sku` require the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.

	-> Note: `auxiliary_mode` and `auxiliary_sku` require the preview feature is enabled. See the [Prerequisites](https://learn.microsoft.com/en-us/azure/networking/nva-accelerated-connections#prerequisites) for more details.
	-> Note: `auxiliary_mode` is in Preview and requires that the preview is enabled - [more information can be found in the Azure documentation](https://learn.microsoft.com/azure/networking/nva-accelerated-connections#prerequisites).

azurerm_network_interface - Support auxiliary_mode, auxiliary_sku #22979

azurerm_network_interface - Support auxiliary_mode, auxiliary_sku #22979

Conversation

ms-zhenhua commented Aug 16, 2023 • edited

Swagger Link

Test Result

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua commented Aug 18, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua Sep 6, 2023 • edited

Choose a reason for hiding this comment

ms-zhenhua commented Sep 6, 2023

Test Result

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua commented Sep 14, 2023

stephybun left a comment

Choose a reason for hiding this comment

`azurerm_network_interface` - Support `auxiliary_mode`, `auxiliary_sku` #22979

`azurerm_network_interface` - Support `auxiliary_mode`, `auxiliary_sku` #22979

ms-zhenhua commented Aug 16, 2023 •

edited

ms-zhenhua Sep 6, 2023 •

edited