Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing public_ip_addresses property to api_management #2310

Conversation

vidarw
Copy link
Contributor

@vidarw vidarw commented Nov 14, 2018

Adds the missing property fields of public_ip_addresses to the terraform api_management resource and data source.

Example code that demonstrates the fixed problem:

provider "azurerm" {}

resource "azurerm_resource_group" "test" {
  name     = "amtestRG-vidarw"
  location = "westeurope"
}

resource "azurerm_api_management" "test" {
  name            = "acctestAM-vidarw"
  publisher_name  = "pub1"
  publisher_email = "pub1@email.com"

  sku {
    name     = "Developer"
    capacity = 1
  }

  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
}

data "azurerm_api_management" "test" {
  name                = "${azurerm_api_management.test.name}"
  resource_group_name = "${azurerm_api_management.test.resource_group_name}"
}

resource "local_file" "foo" {
  content = "${data.azurerm_api_management.test.public_ip_addresses.0}"
  filename = "${path.module}/output.txt"
}

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @vidarw

Thanks for this PR - on the generally looks pretty good to me, if we can fix up the minor issues this otherwise LGTM 👍

Thanks!

website/docs/d/api_management.html.markdown Outdated Show resolved Hide resolved
website/docs/d/api_management.html.markdown Outdated Show resolved Hide resolved
website/docs/r/api_management.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_test.go Outdated Show resolved Hide resolved
azurerm/data_source_api_management_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the 1.19.0 milestone Nov 14, 2018
@tombuildsstuff
Copy link
Member

Tests pass:

screenshot 2018-11-14 at 17 17 57

@tombuildsstuff tombuildsstuff merged commit c96c5e2 into hashicorp:master Nov 14, 2018
tombuildsstuff added a commit that referenced this pull request Nov 14, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants