Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade managed cassandra API version from 2022-05-15 to 2023-04-15 #23110

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Upgrade managed cassandra API version from 2022-05-15 to 2023-04-15 #23110

merged 5 commits into from
Sep 5, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Aug 29, 2023 •
edited by tombuildsstuff
Loading

image

* `azurerm_cosmosdb_cassandra_datacenter` - refactoring to use `hashicorp/go-azure-sdk` [GH-23110]
* `azurerm_cosmosdb_cassandra_datacenter` - updating to API Version `2023-04-15` [GH-23110]

tombuildsstuff
tombuildsstuff approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @neil-yechenwei

Thanks for this PR - I've taken a look through and left a few comments inline, but this is mostly looking good - if we can fix those up then we should be able to take another look and get this merged 👍

Thanks!

internal/services/cosmos/cosmosdb_cassandra_datacenter_resource.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_cassandra_datacenter_resource.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_cassandra_datacenter_resource.go Outdated Show resolved Hide resolved
internal/services/cosmos/cosmosdb_cassandra_datacenter_resource.go Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , thanks for the comment. I updated PR. Please take another look. Thanks.

image

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Sep 4, 2023 •
edited
Loading

image

tombuildsstuff
tombuildsstuff approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.72.0 milestone Sep 5, 2023
@tombuildsstuff
Copy link
Contributor

Pretty sure I approved this earlier, but let's re-approve this 🙃

@tombuildsstuff tombuildsstuff merged commit ab6cf0c into hashicorp:main Sep 5, 2023
22 checks passed
tombuildsstuff added a commit that referenced this pull request Sep 5, 2023
@tombuildsstuff
updating to include #23110
2c645bb
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/cosmosdb size/XL
Projects
None yet
Milestone
v3.72.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neil-yechenwei @tombuildsstuff