Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_security_center_assessment_policy : refactoring to use hashicorp/go-azure-sdk #23158

Merged
merged 3 commits into from Sep 11, 2023
Merged

azurerm_security_center_assessment_policy : refactoring to use hashicorp/go-azure-sdk #23158

merged 3 commits into from Sep 11, 2023

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Sep 4, 2023

Test Result:


=== RUN   TestAccServerVulnerabilityAssessment
--- PASS: TestAccServerVulnerabilityAssessment (267.42s)
=== RUN   TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy
    --- PASS: TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy (267.42s)
=== RUN   TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/basic
        --- PASS: TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/basic (80.27s)
=== RUN   TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/complete
        --- PASS: TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/complete (74.49s)
=== RUN   TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/update
        --- PASS: TestAccServerVulnerabilityAssessment/securityCenterAssessmentPolicy/update (112.67s)
PASS

tombuildsstuff
tombuildsstuff approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things but otherwise 👍

internal/services/securitycenter/client/client.go Outdated Show resolved Hide resolved
internal/services/securitycenter/security_center_assessment_policy_resource_test.go Outdated Show resolved Hide resolved
internal/services/securitycenter/security_center_assessment_policy_resource.go Outdated Show resolved Hide resolved
internal/services/securitycenter/security_center_assessment_policy_resource.go Show resolved Hide resolved
tombuildsstuff
tombuildsstuff approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @sinbai

@tombuildsstuff tombuildsstuff added this to the v3.72.0 milestone Sep 5, 2023
@sinbai
Copy link
Contributor Author

sinbai commented Sep 5, 2023

A few minor things but otherwise 👍

Hi @tombuildsstuff , thanks for your feedback. The code has been updated. Could you please take another look?

@tombuildsstuff tombuildsstuff merged commit 3719463 into hashicorp:main Sep 11, 2023
25 checks passed
@tombuildsstuff tombuildsstuff modified the milestones: v3.72.0, v3.73.0 Sep 11, 2023
tombuildsstuff added a commit that referenced this pull request Sep 11, 2023
@tombuildsstuff
updating to include #23158
59cb07c
@sinbai sinbai deleted the securitycenter/migrate_pandora_sdk_for_assessmentmetadata branch March 28, 2024 02:47
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/security-center size/XL
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinbai @tombuildsstuff