Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_maps_account - Support for local_authentication_enabled #23216

Merged
merged 1 commit into from Sep 8, 2023
Merged

azurerm_maps_account - Support for local_authentication_enabled #23216

merged 1 commit into from Sep 8, 2023

Conversation

SebSa
Copy link
Contributor

@SebSa SebSa commented Sep 7, 2023

Fixes #22856

TF_ACC=1 go test -v ./internal/services/maps -run=TestAccMapsAccount_basic -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"                   
=== RUN   TestAccMapsAccount_basic
=== PAUSE TestAccMapsAccount_basic
=== CONT  TestAccMapsAccount_basic
--- PASS: TestAccMapsAccount_basic (39.55s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/maps  41.995s

TF_ACC=1 go test -v ./internal/services/maps -run=TestAccMapsAccount_disableLocalAuth -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"  
=== RUN   TestAccMapsAccount_disableLocalAuth
=== PAUSE TestAccMapsAccount_disableLocalAuth
=== CONT  TestAccMapsAccount_disableLocalAuth
--- PASS: TestAccMapsAccount_disableLocalAuth (55.66s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/maps  58.027s

mbfrahry
mbfrahry approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @SebSa

@mbfrahry mbfrahry changed the title Support for disable_local_auth attribute for Azure Maps Account azurerm_maps_account - Support for local_authentication_enabled Sep 8, 2023
@mbfrahry mbfrahry added this to the v3.73.0 milestone Sep 8, 2023
@mbfrahry mbfrahry merged commit bc0196b into hashicorp:main Sep 8, 2023
22 checks passed
mbfrahry added a commit that referenced this pull request Sep 8, 2023
@mbfrahry
Update CHANGELOG.md for #23216
d477a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation service/maps size/M
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

Support for disable_local_auth attribute for Azure Maps Account
2 participants
@SebSa @mbfrahry