`azurerm_storage_account` - For `Storage` kind account, avoid setting some unsupported blob properties #23288

magodo · 2023-09-16T03:39:46Z

Test

💤  TF_ACC=1 go test -v -timeout=20h -run='TestAccStorageAccount_blobProperties_kindStorageNotSupportLastAccessTimeEnabled|TestAccStorageAccount_blobProperties' ./internal/services/storage
=== RUN   TestAccStorageAccount_blobProperties
=== PAUSE TestAccStorageAccount_blobProperties
=== RUN   TestAccStorageAccount_blobProperties_containerAndLastAccessTimeDisabled
=== PAUSE TestAccStorageAccount_blobProperties_containerAndLastAccessTimeDisabled
=== RUN   TestAccStorageAccount_blobPropertiesEmptyAllowedExposedHeaders
=== PAUSE TestAccStorageAccount_blobPropertiesEmptyAllowedExposedHeaders
=== RUN   TestAccStorageAccount_blobProperties_kindStorageNotSupportLastAccessTimeEnabled
=== PAUSE TestAccStorageAccount_blobProperties_kindStorageNotSupportLastAccessTimeEnabled
=== CONT  TestAccStorageAccount_blobProperties
=== CONT  TestAccStorageAccount_blobPropertiesEmptyAllowedExposedHeaders
=== CONT  TestAccStorageAccount_blobProperties_kindStorageNotSupportLastAccessTimeEnabled
=== CONT  TestAccStorageAccount_blobProperties_containerAndLastAccessTimeDisabled
--- PASS: TestAccStorageAccount_blobProperties_kindStorageNotSupportLastAccessTimeEnabled (133.00s)
--- PASS: TestAccStorageAccount_blobPropertiesEmptyAllowedExposedHeaders (134.87s)
--- PASS: TestAccStorageAccount_blobProperties_containerAndLastAccessTimeDisabled (180.13s)
--- PASS: TestAccStorageAccount_blobProperties (266.92s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       266.935s

… some unsupported blob properties

tombuildsstuff

Left a few comments elsewhere around the wording, but otherwise 👍

tombuildsstuff · 2023-09-18T04:59:23Z

internal/services/storage/storage_account_resource_test.go

+      days = 7
+    }
+
+    # Following properties are not supported for "Storage" kind


minor but given there's Storage and StorageV2 it's probably worth explicitly calling out this is only for the unversioned/v1 version here?

Suggested change

# Following properties are not supported for "Storage" kind

# Following properties are not supported for "Storage" (V1) kind

tombuildsstuff · 2023-09-18T04:59:30Z

internal/services/storage/storage_account_resource.go

 	if version, ok := v["default_service_version"].(string); ok && version != "" {
 		props.DefaultServiceVersion = utils.String(version)
 	}

-	props.LastAccessTimeTrackingPolicy = &storage.LastAccessTimeTrackingPolicy{
-		Enable: utils.Bool(v["last_access_time_enabled"].(bool)),
+	// `Storage` kind doesn't support:


minor but given there's Storage and StorageV2 it's probably worth explicitly calling out this is only for the unversioned/v1 version here?

tombuildsstuff · 2023-09-18T04:59:33Z

internal/services/storage/storage_account_resource.go

 		},
 	}

+	// `Storage` kind doesn't support:


minor but given there's Storage and StorageV2 it's probably worth explicitly calling out this is only for the unversioned/v1 version here?

tombuildsstuff · 2023-09-18T05:00:45Z

website/docs/r/storage_account.html.markdown

 * `default_service_version` - (Optional) The API Version which should be used by default for requests to the Data Plane API if an incoming request doesn't specify an API Version.

 * `last_access_time_enabled` - (Optional) Is the last access time based tracking enabled? Default to `false`.

+-> **NOTE:** `Storage` kind Storage Account doesn't support `last_access_time_enabled`.


can we update these to be:

Suggested change

-> **NOTE:** `Storage` kind Storage Account doesn't support `last_access_time_enabled`.

-> **NOTE:** This field cannot be configured when `kind` is set to `Storage` (V1).

Whilst I appreciate the Service Team aren't using the V1 label, I think omitting it here would cause confusion that this isn't supported in V2 too, so I think it's worth calling that out?

tombuildsstuff · 2023-09-18T05:02:28Z

internal/services/storage/storage_account_resource.go

+		props.BlobServicePropertiesProperties.IsVersioningEnabled = &versioningEnabled
+	} else {
+		if lastAccessTimeEnabled {
+			return nil, fmt.Errorf("`Storage` kind does not support `last_access_time_enabled`")


(as elsewhere) could we update these slightly:

Suggested change

return nil, fmt.Errorf("`Storage` kind does not support `last_access_time_enabled`")

return nil, fmt.Errorf("`last_access_time_enabled` cannot be configured when `kind` is set to `Storage` (V1)")

}

// [..]

magodo · 2023-09-18T06:38:51Z

@tombuildsstuff Thank you for the comments, and I've resolved them all. Please take another look!

stephybun

Thanks for this @magodo LGTM 👍

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.73.0" to "3.74.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.74.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.74.0
NOTES:

* `azurerm_synapse_sql_pool` - users that have imported `azurerm_synapse_sql_pool` resources that were created outside of Terraform using an `LRS` storage account type will need to use `ignore_changes` to avoid the resource from being destroyed and recreated.

FEATURES:

* **New Resource**: `azurerm_arc_resource_bridge_appliance` ([#23108](https://github.com/hashicorp/terraform-provider-azurerm/issues/23108))
* **New Resource**: `azurerm_data_factory_dataset_azure_sql_table` ([#23264](https://github.com/hashicorp/terraform-provider-azurerm/issues/23264))
* **New Resource**: `azurerm_function_app_connection` ([#23127](https://github.com/hashicorp/terraform-provider-azurerm/issues/23127))

ENHANCEMENTS:

* dependencies: updating to `v0.20230918.1115907` of `github.com/hashicorp/go-azure-sdk` ([#23337](https://github.com/hashicorp/terraform-provider-azurerm/issues/23337))
* dependencies: downgrading to `v1.12.5` of `github.com/rickb777/date` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `mysql`: updating to use API Version `2022-01-01` ([#23320](https://github.com/hashicorp/terraform-provider-azurerm/issues/23320))
* `azurerm_app_configuration` - support for the `replica` block ([#22452](https://github.com/hashicorp/terraform-provider-azurerm/issues/22452))
* `azurerm_bot_channel_directline` - support for `user_upload_enabled`, `endpoint_parameters_enabled`, and `storage_enabled` ([#23149](https://github.com/hashicorp/terraform-provider-azurerm/issues/23149))
* `azurerm_container_app` - support for scale rules ([#23294](https://github.com/hashicorp/terraform-provider-azurerm/issues/23294))
* `azurerm_container_app_environment` - support for zone redundancy ([#23313](https://github.com/hashicorp/terraform-provider-azurerm/issues/23313))
* `azurerm_container_group` - support for the `key_vault_user_identity_id` property for Customer Managed Keys ([#23332](https://github.com/hashicorp/terraform-provider-azurerm/issues/23332))
* `azurerm_cosmosdb_account` - support for MongoDB connection strings ([#23331](https://github.com/hashicorp/terraform-provider-azurerm/issues/23331))
* `azurerm_data_factory_dataset_delimited_text` - support for the `dynamic_file_system_enabled`, `dynamic_path_enabled`, and `dynamic_filename_enabled` properties ([#23261](https://github.com/hashicorp/terraform-provider-azurerm/issues/23261))
* `azurerm_data_factory_dataset_parquet` - support for the `azure_blob_fs_location` block ([#23261](https://github.com/hashicorp/terraform-provider-azurerm/issues/23261))
* `azurerm_monitor_diagnostic_setting` - validation to ensure either `category` or `category_group` are supplied in `enabled_log` and `log` blocks ([#23308](https://github.com/hashicorp/terraform-provider-azurerm/issues/23308))
* `azurerm_network_interface` - support for the `auxiliary_mode` and `auxiliary_sku` properties ([#22979](https://github.com/hashicorp/terraform-provider-azurerm/issues/22979))
* `azurerm_postgresql_flexible_server` - increased the maximum supported value for `storage_mb` ([#23277](https://github.com/hashicorp/terraform-provider-azurerm/issues/23277))
* `azurerm_shared_image_version` - support for the `replicated_region_deletion_enabled` and `target_region.exclude_from_latest_enabled` properties ([#23147](https://github.com/hashicorp/terraform-provider-azurerm/issues/23147))
* `azurerm_storage_account` - support for setting `domain_name` and `domain_guid` for `AADKERB` ([#22833](https://github.com/hashicorp/terraform-provider-azurerm/issues/22833))
* `azurerm_storage_account_customer_managed_key` - support for cross-tenant customer-managed keys with the `federated_identity_client_id`, and `key_vault_uri` properties ([#20356](https://github.com/hashicorp/terraform-provider-azurerm/issues/20356))
* `azurerm_web_application_firewall_policy` - support for the `rate_limit_duration`, `rate_limit_threshold`, `group_rate_limit_by`, and `request_body_inspect_limit_in_kb` properties ([#23239](https://github.com/hashicorp/terraform-provider-azurerm/issues/23239))

BUG FIXES:

* Data Source: `azurerm_container_app_environment`: fix `log_analytics_workspace_name` output to correct value ([#23298](https://github.com/hashicorp/terraform-provider-azurerm/issues/23298))
* `azurerm_api_management_api` - set the `service_url` property when importing the resource ([#23011](https://github.com/hashicorp/terraform-provider-azurerm/issues/23011))
* `azurerm_app_configuration` - prevent crash by nil checking the encryption configuration ([#23302](https://github.com/hashicorp/terraform-provider-azurerm/issues/23302))
* `azurerm_app_configuration_feature` - update `percentage_filter_value` to accept correct type of float ([#23263](https://github.com/hashicorp/terraform-provider-azurerm/issues/23263))
* `azurerm_container_app` - fix an issue with `commands` and `args` being overwritten when using multiple containers ([#23338](https://github.com/hashicorp/terraform-provider-azurerm/issues/23338))
* `azurerm_key_vault_certificate` - fix issue where certificates couldn't be recovered anymore ([#23204](https://github.com/hashicorp/terraform-provider-azurerm/issues/23204))
* `azurerm_key_vault_key` - the ForceNew when `expiration_date` is removed from the config file ([#23327](https://github.com/hashicorp/terraform-provider-azurerm/issues/23327))
* `azurerm_linux_function_app` - fix a bug in setting the storage settings when using Elastic Premium plans ([#21212](https://github.com/hashicorp/terraform-provider-azurerm/issues/21212))
* `azurerm_linux_web_app` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_linux_web_app` - fix crash in auto heal expansion ([#21328](https://github.com/hashicorp/terraform-provider-azurerm/issues/21328))
* `azurerm_linux_web_app_slot` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_linux_web_app_slot` - fix crash in auto heal expansion ([#21328](https://github.com/hashicorp/terraform-provider-azurerm/issues/21328))
* `azurerm_log_analytics_solution` - fix bug where the resource wasn't handling successful creation on subsequent applies ([#23312](https://github.com/hashicorp/terraform-provider-azurerm/issues/23312))
* `azurerm_management_group_subscription_association` - fix bug to correctly mark resource as gone if not found during read ([#23335](https://github.com/hashicorp/terraform-provider-azurerm/issues/23335))
* `azurerm_mssql_elasticpool` - remove check that prevents `license_type` from being set for certain skus ([#23262](https://github.com/hashicorp/terraform-provider-azurerm/issues/23262))
* `azurerm_servicebus_queue` - fixing an issue where `auto_delete_on_idle` couldn't be set to `P10675199DT2H48M5.4775807S` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `azurerm_servicebus_topic` - fixing an issue where `auto_delete_on_idle` couldn't be set to `P10675199DT2H48M5.4775807S` ([#23296](https://github.com/hashicorp/terraform-provider-azurerm/issues/23296))
* `azurerm_storage_account` - prevent sending unsupported blob properties in payload for `Storage` account kind ([#23288](https://github.com/hashicorp/terraform-provider-azurerm/issues/23288))
* `azurerm_synapse_sql_pool` - expose `storage_account_type` ([#23217](https://github.com/hashicorp/terraform-provider-azurerm/issues/23217))
* `azurerm_windows_function_app` - fix a bug in setting the storage settings when using Elastic Premium plans ([#21212](https://github.com/hashicorp/terraform-provider-azurerm/issues/21212))
* `azurerm_windows_web_app` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))
* `azurerm_windows_web_app_slot` - fix docker app stack update ([#23303](https://github.com/hashicorp/terraform-provider-azurerm/issues/23303))

DEPRECATIONS:

* `azurerm_application_gateway` - deprecate `Standard` and `WAF` skus ([#23310](https://github.com/hashicorp/terraform-provider-azurerm/issues/23310))
* `azurerm_bot_channel_web_chat` - deprecate `site_names` in favour of `site` block ([#23161](https://github.com/hashicorp/terraform-provider-azurerm/issues/23161))
* `azurerm_monitor_diagnostic_setting` - deprecate `retention_policy` in favour of `azurerm_storage_management_policy` ([#23260](https://github.com/hashicorp/terraform-provider-azurerm/issues/23260))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

azurerm_storage_account - For Storage kind account, avoid setting…

0f1909a

… some unsupported blob properties

magodo added bug service/storage labels Sep 16, 2023

magodo marked this pull request as ready for review September 16, 2023 03:40

github-actions bot added documentation size/L labels Sep 16, 2023

tombuildsstuff requested changes Sep 18, 2023

View reviewed changes

github-actions bot added the waiting-response label Sep 18, 2023

Explicitly mention Storage v1

6d74e4e

github-actions bot removed the waiting-response label Sep 18, 2023

stephybun approved these changes Sep 18, 2023

View reviewed changes

stephybun merged commit f50e3ca into hashicorp:main Sep 18, 2023
23 checks passed

github-actions bot added this to the v3.74.0 milestone Sep 18, 2023

stephybun added a commit that referenced this pull request Sep 20, 2023

Update for #23011 #23277 #23260 #22833 #23288 #23147 #22979

e266595

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_storage_account` - For `Storage` kind account, avoid setting some unsupported blob properties #23288

`azurerm_storage_account` - For `Storage` kind account, avoid setting some unsupported blob properties #23288

magodo commented Sep 16, 2023

tombuildsstuff left a comment

tombuildsstuff Sep 18, 2023

tombuildsstuff Sep 18, 2023

tombuildsstuff Sep 18, 2023

tombuildsstuff Sep 18, 2023

tombuildsstuff Sep 18, 2023

magodo commented Sep 18, 2023

stephybun left a comment

	# Following properties are not supported for "Storage" kind
	# Following properties are not supported for "Storage" (V1) kind

	-> NOTE: `Storage` kind Storage Account doesn't support `last_access_time_enabled`.
	-> NOTE: This field cannot be configured when `kind` is set to `Storage` (V1).

azurerm_storage_account - For Storage kind account, avoid setting some unsupported blob properties #23288

azurerm_storage_account - For Storage kind account, avoid setting some unsupported blob properties #23288

Conversation

magodo commented Sep 16, 2023

Test

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Sep 18, 2023

Choose a reason for hiding this comment

tombuildsstuff Sep 18, 2023

Choose a reason for hiding this comment

tombuildsstuff Sep 18, 2023

Choose a reason for hiding this comment

tombuildsstuff Sep 18, 2023

Choose a reason for hiding this comment

tombuildsstuff Sep 18, 2023

Choose a reason for hiding this comment

magodo commented Sep 18, 2023

stephybun left a comment

Choose a reason for hiding this comment

`azurerm_storage_account` - For `Storage` kind account, avoid setting some unsupported blob properties #23288

`azurerm_storage_account` - For `Storage` kind account, avoid setting some unsupported blob properties #23288