New Resource: azurerm_netapp_account_encryption
#23733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfrahry
reviewed
Nov 6, 2023
mbfrahry
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Hey @paulomarquesc, this looks nearly there. I just see one example file not having an example but other than that, I think we are good to go
| @@ -0,0 +1,5 @@ | |||
| ## Example: NetApp Files Customer-Managed Keys Volume Encryption | |||
|
|
|||
| This example shows how to create an Azure NetApp volume with Customer-Managed Key Encryption enabled. | |||
There was a problem hiding this comment.
This file doesn't have an example
There was a problem hiding this comment.
I completely missed that. I'll update that today.
There was a problem hiding this comment.
Actually, it is there:
I was following the format other services are doing, where they add a README.md file with a description similar to what I included and then provide the variables.tf and main.tf with the actual example.
Did that change?
There was a problem hiding this comment.
🤦 you are right! Thanks for the follow-up
mbfrahry
changed the title
azurerm_netapp_account_encryption
|
This functionality has been released in v3.89.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
Jan 25, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.88.0" to "3.89.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.89.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.89.0
FEATURES:

*
New Data Source: `azurerm_data_factory_trigger_schedule`
([#24572](https://github.com/hashicorp/terraform-provider-azurerm/issues/24572))
*
New Data Source: `azurerm_data_factory_trigger_schedules`
([#24572](https://github.com/hashicorp/terraform-provider-azurerm/issues/24572))
*
New Data Source: `azurerm_ip_groups`
([#24540](https://github.com/hashicorp/terraform-provider-azurerm/issues/24540))
*
New Data Source: `azurerm_nginx_certificate`
([#24577](https://github.com/hashicorp/terraform-provider-azurerm/issues/24577))
*
New Resource: `azurerm_chaos_studio_target`
([#24580](https://github.com/hashicorp/terraform-provider-azurerm/issues/24580))
*
New Resource: `azurerm_elastic_san_volume_group`
([#24166](https://github.com/hashicorp/terraform-provider-azurerm/issues/24166))
*
New Resource: `azurerm_netapp_account_encryption`
([#23733](https://github.com/hashicorp/terraform-provider-azurerm/issues/23733))
*
New Resource: `azurerm_redhat_openshift_cluster`
([#24375](https://github.com/hashicorp/terraform-provider-azurerm/issues/24375))

ENHANCEMENTS:

*
dependencies: updating to `v0.66.1` of
`github.com/hashicorp/go-azure-helpers`
([#24561](https://github.com/hashicorp/terraform-provider-azurerm/issues/24561))
*
dependencies: updating to `v0.20240124.1115501` of
`github.com/hashicorp/go-azure-sdk`
([#24619](https://github.com/hashicorp/terraform-provider-azurerm/issues/24619))
*
`bot`: updating to API Version `2021-05-01-preview`
([#24555](https://github.com/hashicorp/terraform-provider-azurerm/issues/24555))
*
`containerservice`: the SDK Clients now support logging
([#24564](https://github.com/hashicorp/terraform-provider-azurerm/issues/24564))
*
`cosmosdb`: updating to API Version `2023-04-15`
([#24541](https://github.com/hashicorp/terraform-provider-azurerm/issues/24541))
*
`loadtestservice`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest` (and support
logging)
([#24578](https://github.com/hashicorp/terraform-provider-azurerm/issues/24578))
*
`managedidentity`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest` (and support
logging)
([#24578](https://github.com/hashicorp/terraform-provider-azurerm/issues/24578))
*
`azurerm_api_management_api` - change the `id` format so specific
`revision`s can be managed by Terraform
([#23031](https://github.com/hashicorp/terraform-provider-azurerm/issues/23031))
*
`azurerm_data_protection_backup_vault` - the `redundancy` propety can
now be set to `ZoneRedundant`
([#24556](https://github.com/hashicorp/terraform-provider-azurerm/issues/24556))
*
`azurerm_data_factory_integration_runtime_azure_ssis` - support for the
`credential_name` property
([#24458](https://github.com/hashicorp/terraform-provider-azurerm/issues/24458))
*
`azurerm_orchestrated_virtual_machine_scale_set` - support
`2022-datacenter-azure-edition-hotpatch` and
`2022-datacenter-azure-edition-hotpatch-smalldisk` hotpatching images
([#23500](https://github.com/hashicorp/terraform-provider-azurerm/issues/23500))
*
`azurerm_stream_analytics_job` - support for the `sku_name` property
([#24554](https://github.com/hashicorp/terraform-provider-azurerm/issues/24554))

BUG
FIXES:

* Data Source: `azurerm_app_service` - parsing the API
Response for `app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
Data Source: `azurerm_function_app` - parsing the API Response for
`app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
`azurerm_app_configuration_key` - the value for the `value` property can
now be removed/emptied
([#24582](https://github.com/hashicorp/terraform-provider-azurerm/issues/24582))

*
`azurerm_app_service` - parsing the API Response for
`app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
`azurerm_app_service_plan` - fix casing in `serverFarms` due to ID
update
([#24562](https://github.com/hashicorp/terraform-provider-azurerm/issues/24562))
*
`azurerm_app_service_slot` - parsing the API Response for
`app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
`azurerm_automation_schedule` - only one `monthly_occurence` block can
now be specified
([#24614](https://github.com/hashicorp/terraform-provider-azurerm/issues/24614))
*
`azurerm_cognitive_deployment` - the `model.version` property is no
longer required
([#24264](https://github.com/hashicorp/terraform-provider-azurerm/issues/24264))
*
`azurerm_container_app` - multiple `custom_scale_rule` can not be
updated
([#24509](https://github.com/hashicorp/terraform-provider-azurerm/issues/24509))
*
`azurerm_container_registry_task_schedule_run_now` - prevent issue where
the incorrect scheduled run in tracked if there have been multiple
([#24592](https://github.com/hashicorp/terraform-provider-azurerm/issues/24592))
*
`azurerm_function_app` - parsing the API Response for
`app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
`azurerm_function_app_slot` - parsing the API Response for
`app_service_plan_id` case-insensitively
([#24626](https://github.com/hashicorp/terraform-provider-azurerm/issues/24626))
*
`azurerm_logic_app_standard` - now will parse the app service ID
insensitively
([#24562](https://github.com/hashicorp/terraform-provider-azurerm/issues/24562))
*
`azurerm_logic_app_workflow` - the `workflow_parameters` will now
correctly handle information specified by `$connections`
([#24141](https://github.com/hashicorp/terraform-provider-azurerm/issues/24141))
*
`azurerm_mssql_managed_instance_security_alert_policy` - can not update
empty storage attributes
([#24553](https://github.com/hashicorp/terraform-provider-azurerm/issues/24553))
*
`azurerm_network_interface` - the `ip_configuration` properties are no
longer added to a Load Balancer Backend if one of those
`ip_configurations` is associated with a backend
([#24470](https://github.com/hashicorp/terraform-provider-azurerm/issues/24470))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1052/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for customer-managed keys encryption through the following:
azurerm_netapp_account_encryptionnew resource to enable encryption settings on NetApp accountencryption_key_sourceandkey_vault_private_endpoint_id