Support for TCP type & ExposedPort on azurerm_container_app

[SpartakusMd]

• Added the missing doc that TCP type is supported. Result of containerapps: updating to API Version 2023-05-01 #22804
• Added missing option for ExposedPort
• GO Azure SDK https://github.com/hashicorp/go-azure-sdk/blob/main/resource-manager/containerapps/2023-05-01/containerapps/model_ingress.go

Fixes #23738 #21133 #22755

[stephybun]

Thanks for this PR @SpartakusMd.

Overall this looks good, but the test needs to be updated to use the config that you added in this PR and the documentation would also need an update.

Once that's done I can run the test and see if we can get this merged.

[stephybun]

New test failure 🙃 - I'm no SME on ContainerApps so I'm not sure how specific the configuration will need to be in order to use exposed_port or how much validation we should be putting into the resource to prevent users from running into this kind of error.

@jackofallops perhaps you could provide a little bit of guidance here?

------- Stdout: -------
=== RUN   TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== CONT  TestAccContainerAppResource_completeTcpExposedPort
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: creating Container App (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-231101121940949762"
        Container App Name: "acctest-capp-231101121940949762"): performing CreateOrUpdate: containerapps.ContainerAppsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="ContainerAppTcpRequiresVnet" Message="Applications with external TCP ingress can only be deployed to Container App Environments that have a custom VNET. Set ingress traffic to 'Limited to Container Apps Environment' if you want to deploy to a Container App Environment without a custom VNET. For more information on custom VNETs, please visit https://go.microsoft.com/fwlink/?linkid=2238174
          with azurerm_container_app.test,
          on terraform_plugin_test.tf line 130, in resource "azurerm_container_app" "test":
         130: resource "azurerm_container_app" "test" {
        creating Container App (Subscription: "*******"
        Resource Group Name: "acctestRG-CAEnv-231101121940949762"
        Container App Name: "acctest-capp-231101121940949762"): performing
        CreateOrUpdate: containerapps.ContainerAppsClient#CreateOrUpdate: Failure
        sending request: StatusCode=0 -- Original Error:
        Code="ContainerAppTcpRequiresVnet" Message="Applications with external TCP
        ingress can only be deployed to Container App Environments that have a custom
        VNET. Set ingress traffic to 'Limited to Container Apps Environment' if you
        want to deploy to a Container App Environment without a custom VNET. For more
        information on custom VNETs, please visit
        https://go.microsoft.com/fwlink/?linkid=2238174
--- FAIL: TestAccContainerAppResource_completeTcpExposedPort (1162.14s)
FAIL

[jackofallops]

New test failure 🙃 - I'm no SME on ContainerApps so I'm not sure how specific the configuration will need to be in order to use exposed_port or how much validation we should be putting into the resource to prevent users from running into this kind of error.

@jackofallops perhaps you could provide a little bit of guidance here?

@SpartakusMd / @stephybun - The config is missing a user defined subnet to attach to the Container App Environment, using templateWithVnet in place of templatePlusExtras I think will resolve that. fwiw, a lot of the config in the completeTcpExposedPort test can be removed as it only needs to test the new property / ingress block (e.g. the extended container config for probes and volumes, since they're unrelated to the change and provide no additional benefit here)

[SpartakusMd]

Switched to use templateWithVnet and did some cleanup. Hopefully it's enough 🤞 But I believe it needs infrastructure_subnet_id on the azurerm_container_app_environment but it's missing. Am I rigth?

If it will fail again the test, I will another app environment with everything necessary for the Vnet.

[stephybun]

@SpartakusMd third times a charm - test passed! 🎉

Just need to fix up the terraform linting that the GitHub Action is flagging then this should be good to go!

[SpartakusMd]

@stephybun perfect. Fixed the linting too.

[stephybun]

Thanks @SpartakusMd LGTM 💯