Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: adding a test ensuring that Data Sources do not support import #23820

Merged
merged 4 commits into from Nov 8, 2023

Conversation

tombuildsstuff
Copy link
Member

This PR fixes an issue spotted where 3 data sources incorrectly define import functions, which aren't valid - so these aren't usable by first adding a test to detect the issue and then removing the importer functions as needed.

This isn't possible for Data Sources, therefore Data Sources shouldn't be defining
an `Importer`
This isn't supported for Data Sources so is invalid
This isn't valid for a data source
This isn't valid for Data Sources, so should be removed
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ac2a612 into main Nov 8, 2023
20 checks passed
@tombuildsstuff tombuildsstuff deleted the b/schema-data-sources-cannot-support-import branch November 8, 2023 14:41
tombuildsstuff added a commit that referenced this pull request Nov 8, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Nov 10, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.79.0&#34; to
&#34;3.80.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.80.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.80.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`internal/sdk` - Added support for pointer Types in resource models
([#23810](https://github.com/hashicorp/terraform-provider-azurerm/issues/23810))&#xA;*
dependencies: updating to `v0.63.0` of
`github.com/hashicorp/go-azure-helpers`
([#23785](https://github.com/hashicorp/terraform-provider-azurerm/issues/23785))&#xA;*
dependencies: updating to `v0.20231106.1151347` of
`github.com/hashicorp/go-azure-sdk`
([#23787](https://github.com/hashicorp/terraform-provider-azurerm/issues/23787))&#xA;*
`azurerm_cognitive_deployment` - support for the
`version_upgrade_option` property
([#22520](https://github.com/hashicorp/terraform-provider-azurerm/issues/22520))&#xA;*
`azurerm_firewall_policy_rule_collection_group` - add support for the
property `http_headers`
([#23641](https://github.com/hashicorp/terraform-provider-azurerm/issues/23641))&#xA;*
`azurerm_kubernetes_cluster` - `fips_enabled` can be updated in the
`default_node_pool` without recreating the cluster
([#23612](https://github.com/hashicorp/terraform-provider-azurerm/issues/23612))&#xA;*
`azurerm_kusto_cluster` - the cluster `name` can now include dashes
([#23790](https://github.com/hashicorp/terraform-provider-azurerm/issues/23790))&#xA;*
`azurerm_postgresql_database` - update the validation of `collation` to
include support for `French_France.1252`
([#23783](https://github.com/hashicorp/terraform-provider-azurerm/issues/23783))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_data_protection_backup_vault` -
removing `import` support, since Data Sources don&#39;t support being
imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))&#xA;*
Data Source: `azurerm_kusto_database` - removing `import` support, since
Data Sources don&#39;t support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))&#xA;*
Data Source: `azurerm_virtual_hub_route_table` - removing `import`
support, since Data Sources don&#39;t support being imported
([#23820](https://github.com/hashicorp/terraform-provider-azurerm/issues/23820))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants