DDOS Protection Plan: refactoring to use hashicorp/go-azure-sdk
#23849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofallops
approved these changes
Nov 9, 2023
… being nil when explicitly unset in the API
tombuildsstuff
force-pushed
the
refactor/ddos-protection-plan-to-use-go-azure-sdk
branch
from
04c948a
to
934586b
Compare
tombuildsstuff
deleted the
refactor/ddos-protection-plan-to-use-go-azure-sdk
branch
tombuildsstuff
added a commit
that referenced
this pull request
Nov 10, 2023
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
Nov 17, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/azurerm" updated from "3.80.0" to
"3.81.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>3.81.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.81.0
ENHANCEMENTS:

*
dependencies: updating to `v0.20231116.1162710` of
`github.com/hashicorp/go-azure-sdk`
([#23922](https://github.com/hashicorp/terraform-provider-azurerm/issues/23922))
*
`managedservices`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))
*
`network`: updating to API Version `2023-06-01`
([#23875](https://github.com/hashicorp/terraform-provider-azurerm/issues/23875))
*
`servicelinker`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))
*
`storage`: refactoring usages of `github.com/hashicorp/go-azure-sdk` to
use the base layer from `hashicorp/go-azure-sdk` rather than
`Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))
*
Data Source: `azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](https://github.com/hashicorp/terraform-provider-azurerm/issues/23849))
*
`azurerm_linux_function_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_linux_function_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_linux_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_linux_web_app_slot` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_logic_app_integration_account_certificate` - `name` now accepts
underscores
([#23866](https://github.com/hashicorp/terraform-provider-azurerm/issues/23866))
*
`azurerm_logic_app_integration_account_partner` -
`business_identity.value` now accepts underscores
([#23866](https://github.com/hashicorp/terraform-provider-azurerm/issues/23866))
*
`azurerm_monitor_data_collection_rule` - added support for
`WorkspaceTransforms` as `kind`
([#23873](https://github.com/hashicorp/terraform-provider-azurerm/issues/23873))
*
`azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](https://github.com/hashicorp/terraform-provider-azurerm/issues/23849))
*
`azurerm_windows_function_app` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_windows_function_app_slot` - add support for disabling Basic
Auth for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_windows_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))
*
`azurerm_windows_web_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))


</pre>
</details>
</details>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
azurerm_network_ddos_protection_planData Source and Resource to usehashicorp/go-azure-sdkChangelog:
Tests look fine for this locally