Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring managedservices, servicelinker and storage to use the hashicorp/go-azure-sdk base layer #23890

Conversation

tombuildsstuff
Copy link
Member

This PR refactors the managedservices, servicelinker and storage services over to using the new base layer from hashicorp/go-azure-sdk - by updating to v0.20231114.1115341.

* dependencies: updating to `v0.20231114.1115341` of `github.com/hashicorp/go-azure-sdk`
* `managedservices`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
* `servicelinker`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
* `storage`: refactoring usages of `github.com/hashicorp/go-azure-sdk` to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest`

@tombuildsstuff
Copy link
Member Author

The relevant tests look good 👍

Lighthouse:

Screenshot 2023-11-14 at 15 06 51

Service Connector:

Screenshot 2023-11-14 at 15 06 36

Storage:

Screenshot 2023-11-14 at 15 07 04

@tombuildsstuff tombuildsstuff added this to the v3.81.0 milestone Nov 14, 2023
@tombuildsstuff tombuildsstuff requested a review from a team November 14, 2023 14:21
@tombuildsstuff tombuildsstuff removed their assignment Nov 14, 2023
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit c798299 into main Nov 14, 2023
21 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/managedservices-servicelinker-storage-to-new-base-layer branch November 14, 2023 17:20
tombuildsstuff added a commit that referenced this pull request Nov 14, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Nov 17, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.80.0&#34; to
&#34;3.81.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.81.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.81.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20231116.1162710` of
`github.com/hashicorp/go-azure-sdk`
([#23922](https://github.com/hashicorp/terraform-provider-azurerm/issues/23922))&#xA;*
`managedservices`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))&#xA;*
`network`: updating to API Version `2023-06-01`
([#23875](https://github.com/hashicorp/terraform-provider-azurerm/issues/23875))&#xA;*
`servicelinker`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))&#xA;*
`storage`: refactoring usages of `github.com/hashicorp/go-azure-sdk` to
use the base layer from `hashicorp/go-azure-sdk` rather than
`Azure/go-autorest`
([#23890](https://github.com/hashicorp/terraform-provider-azurerm/issues/23890))&#xA;*
Data Source: `azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](https://github.com/hashicorp/terraform-provider-azurerm/issues/23849))&#xA;*
`azurerm_linux_function_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_linux_function_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_linux_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_linux_web_app_slot` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_logic_app_integration_account_certificate` - `name` now accepts
underscores
([#23866](https://github.com/hashicorp/terraform-provider-azurerm/issues/23866))&#xA;*
`azurerm_logic_app_integration_account_partner` -
`business_identity.value` now accepts underscores
([#23866](https://github.com/hashicorp/terraform-provider-azurerm/issues/23866))&#xA;*
`azurerm_monitor_data_collection_rule` - added support for
`WorkspaceTransforms` as `kind`
([#23873](https://github.com/hashicorp/terraform-provider-azurerm/issues/23873))&#xA;*
`azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](https://github.com/hashicorp/terraform-provider-azurerm/issues/23849))&#xA;*
`azurerm_windows_function_app` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_windows_function_app_slot` - add support for disabling Basic
Auth for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_windows_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;*
`azurerm_windows_web_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants