Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure Firewall Application rules #2501

Closed
RobertNorthard opened this issue Dec 12, 2018 · 7 comments
Closed

Add support for Azure Firewall Application rules #2501

RobertNorthard opened this issue Dec 12, 2018 · 7 comments

Comments

@RobertNorthard
Copy link

RobertNorthard commented Dec 12, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Azure Firewall resource currently only support network rules. I would also like to set application rules. This enables FQDN to be used opposed to IPs.

Potential Terraform Configuration

References

@metacpp
Copy link
Contributor

metacpp commented Dec 13, 2018

Thanks @RobertNorthard for opening this feature request. I'd like to take a look at the SDK support firstly, will let you know the updates soon.

@hbuckle
Copy link
Contributor

hbuckle commented Dec 14, 2018

I have this pretty much ready to go, just waiting for #2433 to be finished before submitting the PR

@maxime-lamarre
Copy link

@hbuckle do you still have the PR handy ?

@hbuckle
Copy link
Contributor

hbuckle commented Jan 14, 2019

It's all done and was released in 1.21.0

@metacpp metacpp added this to the 1.21.0 milestone Jan 15, 2019
@metacpp
Copy link
Contributor

metacpp commented Jan 15, 2019

Thanks @hbuckle for the great contribution (#2532), I will close this feature request.

@metacpp metacpp closed this as completed Jan 15, 2019
@RobertNorthard
Copy link
Author

This is great thank you @hbuckle

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants