Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_subscription - fix checkExistingAliases #25181

Merged
merged 1 commit into from Mar 19, 2024

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Mar 8, 2024

resolves #25164

related with 7a71d37#diff-7a898f7000607cd3fe4064bff824a14a22ac263988337e492bccb9ef70691049L506-R507

seems no need to fire error if no alias is found.

@tombuildsstuff
Copy link
Member

(deleted my previous comment, misread the diff) - although I suspect there's still an OData issue that's the underlying issue here: #24948

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 88f46a8 into hashicorp:main Mar 19, 2024
29 checks passed
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 19, 2024
tombuildsstuff added a commit that referenced this pull request Mar 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating a azurerm_subscription resource with 3.94 version
2 participants