Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_data_lake_gen2_path - Add context deadline in importer #25282

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 18, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

New Feature Submissions

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why below)

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Documentation Changes

  • Documentation is written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.

Description

This PR fixes the failing test cases (as detected in the teamcity), which returns error as below:

------- Stdout: -------
=== RUN   TestAccStorageDataLakeGen2Path_withSuperUsers
=== PAUSE TestAccStorageDataLakeGen2Path_withSuperUsers
=== CONT  TestAccStorageDataLakeGen2Path_withSuperUsers
    testcase.go:113: Step 2/2 error running import: exit status 1
        Error: retrieving File System "fstest" for Data Lake Gen2 Path "testpath" in Account "acctestaccqhdei": building request: internal-error: the context used must have a deadline attached for polling purposes, but got no deadline
--- FAIL: TestAccStorageDataLakeGen2Path_withSuperUsers (174.49s)
FAIL

Testing Logs/Evidence

TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccStorageDataLakeGen2Path_basic'
=== RUN TestAccStorageDataLakeGen2Path_basic
=== PAUSE TestAccStorageDataLakeGen2Path_basic
=== CONT TestAccStorageDataLakeGen2Path_basic
--- PASS: TestAccStorageDataLakeGen2Path_basic (326.94s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/storage 326.958s

Related Issue(s)

This PR fixes the acctests as is detected in https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_STORAGE/118781?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildTestsSection=true

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_storage_data_lake_gen2_path - Fix an import error [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@magodo magodo changed the title azurerm_storage_datalake_gen2_path - Add context deadline in importer azurerm_storage_data_lake_gen2_path - Add context deadline in importer Mar 18, 2024
@magodo magodo added the bug label Mar 18, 2024
@magodo magodo requested a review from manicminer March 18, 2024 05:52
api.json Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ccfaee7 into hashicorp:main Mar 19, 2024
31 checks passed
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 19, 2024
tombuildsstuff added a commit that referenced this pull request Mar 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants