Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating to v0.25.5 of github.com/tombuildsstuff/giovanni #25525

Merged
merged 1 commit into from Apr 8, 2024

Conversation

tombuildsstuff
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR fixes #25521 by ensuring that we nil-check the API Response before trying to parse it. It also fixes an issue with azurerm_storage_share_file where files using Content-Types other than JSON/XML would fail to decode.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer manicminer merged commit 35c24aa into main Apr 8, 2024
24 checks passed
@manicminer manicminer deleted the dependencies/giovanni branch April 8, 2024 10:50
manicminer added a commit that referenced this pull request Apr 8, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Apr 15, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.98.0&#34; to &#34;3.99.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.99.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.99.0&#xA;BREAKING
CHANGE: &#xA;&#xA;* `azurerm_linux_web_app` -
`site_config.0.application_stack.0.java_version` must be specified with
`java_server` and `java_server_version`
([#25553](https://github.com/hashicorp/terraform-provider-azurerm/issues/25553))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240411.1104331` of
`github.com/hashicorp/go-azure-sdk/resourcemanager` and
`github.com/hashicorp/go-azure-sdk/sdk`
([#25546](https://github.com/hashicorp/terraform-provider-azurerm/issues/25546))&#xA;*
dependencies: updating to `v0.26.1` of
`github.com/tombuildsstuff/giovanni`
([#25551](https://github.com/hashicorp/terraform-provider-azurerm/issues/25551))&#xA;*
`azurerm_key_vault` - deprecate the `contact` property from v3.x
provider and update properties to Computed &amp; Optional
([#25552](https://github.com/hashicorp/terraform-provider-azurerm/issues/25552))&#xA;*
`azurerm_key_vault_certificate_contacts` - in v4.0 make the `contact`
property optional to allow for deletion of contacts from the key vault
([#25552](https://github.com/hashicorp/terraform-provider-azurerm/issues/25552))&#xA;*
`azurerm_signalr_service` - support for setting the `sku` property to
`Premium_P2`
([#25578](https://github.com/hashicorp/terraform-provider-azurerm/issues/25578))&#xA;*
`azurerm_snapshot` - support for the `network_access_policy` and
`public_network_access_enabled` properties
([#25421](https://github.com/hashicorp/terraform-provider-azurerm/issues/25421))&#xA;*
`azurerm_storage_account` - extend the support level of
`(blob|queue|share)_properties` for Storage kind
([#25427](https://github.com/hashicorp/terraform-provider-azurerm/issues/25427))&#xA;*
`azurerm_storage_blob` - support for the `encryption_scope` property
([#25551](https://github.com/hashicorp/terraform-provider-azurerm/issues/25551))&#xA;*
`azurerm_storage_container` - support for the `default_encryption_scope`
and `encryption_scope_override_enabled` properties
([#25551](https://github.com/hashicorp/terraform-provider-azurerm/issues/25551))&#xA;*
`azurerm_storage_data_lake_gen2_filesystem` - support for the
`default_encryption_scope` property
([#25551](https://github.com/hashicorp/terraform-provider-azurerm/issues/25551))&#xA;*
`azurerm_subnet` - the `delegation.x.service_delegation.x.name` property
now supports `Oracle.Database/networkAttachments`
([#25571](https://github.com/hashicorp/terraform-provider-azurerm/issues/25571))&#xA;*
`azurerm_web_pubsub` - support setting the `sku` property to
`Premium_P2`
([#25578](https://github.com/hashicorp/terraform-provider-azurerm/issues/25578))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* provider: fix an issue where the provider was not
correctly configured when using a custom metadata host
([#25546](https://github.com/hashicorp/terraform-provider-azurerm/issues/25546))&#xA;*
storage: fix a number of potential crashes during plan/apply with
resources using the Storage data plane API
([#25525](https://github.com/hashicorp/terraform-provider-azurerm/issues/25525))&#xA;*
`azurerm_application_insights` - fix issue where the wrong Application
ID was set into the property `app_id`
([#25520](https://github.com/hashicorp/terraform-provider-azurerm/issues/25520))&#xA;*
`azurerm_application_insights_api_key` - add a state migration to
re-case static segments of the resource ID
([#25567](https://github.com/hashicorp/terraform-provider-azurerm/issues/25567))&#xA;*
`azurerm_container_app_environment_certificate` - the `subject_name`
attribute is now correctly populated
([#25516](https://github.com/hashicorp/terraform-provider-azurerm/issues/25516))&#xA;*
`azurerm_function_app_slot` - will now taint the resource when partially
created
([#24520](https://github.com/hashicorp/terraform-provider-azurerm/issues/24520))&#xA;*
`azurerm_linux_function_app` - will now taint the resource when
partially created
([#24520](https://github.com/hashicorp/terraform-provider-azurerm/issues/24520))&#xA;*
`azurerm_managed_disk` - filtering the Resource SKUs response to reduce
the memory overhead, when determining whether a Managed Disk can be
online resized or not
([#25549](https://github.com/hashicorp/terraform-provider-azurerm/issues/25549))&#xA;*
`azurerm_monitor_alert_prometheus_rule_group` - the `severity` property
is now set correctly when `0`
([#25408](https://github.com/hashicorp/terraform-provider-azurerm/issues/25408))&#xA;*
`azurerm_monitor_smart_detector_alert_rule` - normalising the value for
`id` within the `action_group` block
([#25559](https://github.com/hashicorp/terraform-provider-azurerm/issues/25559))&#xA;*
`azurerm_redis_cache_access_policy_assignment` - the `object_id_alias`
property now allows usernames
([#25523](https://github.com/hashicorp/terraform-provider-azurerm/issues/25523))&#xA;*
`azurerm_windows_function_app` - will not taint the resource when
partially created
([#24520](https://github.com/hashicorp/terraform-provider-azurerm/issues/24520))&#xA;*
`azurerm_windows_function_app` - will not taint the resource when
partially created
([#24520](https://github.com/hashicorp/terraform-provider-azurerm/issues/24520))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
`azurerm_cosmosdb_account` - the `connection_strings` property has been
superseded by the primary and secondary connection strings for sql,
mongodb and readonly
([#25510](https://github.com/hashicorp/terraform-provider-azurerm/issues/25510))&#xA;*
`azurerm_cosmosdb_account` - the `enable_free_tier` property has been
superseded by `free_tier_enabled`
([#25510](https://github.com/hashicorp/terraform-provider-azurerm/issues/25510))&#xA;*
`azurerm_cosmosdb_account` - the `enable_multiple_write_locations`
property has been superseded by `multiple_write_locations_enabled`
([#25510](https://github.com/hashicorp/terraform-provider-azurerm/issues/25510))&#xA;*
`azurerm_cosmosdb_account` - the `enable_automatic_failover` property
has been superseded by `automatic_failover_enabled`
([#25510](https://github.com/hashicorp/terraform-provider-azurerm/issues/25510))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/105/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

github-actions bot commented May 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants