azurerm_mssql_managed_database - allow RestorableDatabaseID to be used for point in time restore

[catriona-m]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This pr adds validation for RestorableDatabaseID and allows them to be used for point in time restores of mssql_managed_database

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

Tested this manually:

• Create an azurem_mssql_managed_database using tf
• Destroy the azurem_mssql_managed_database using tf
• Retrieve restorable db id and point in time restore time from backups in mssql_managed_instance and populate point_in_time_restore block with these and apply

• azurerm_mssql_managed_database_resource - allow RestorableDatabaseID to be used for point in time restore [GH-00000]

This is a (please select all that apply):

• [] Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

[stephybun]

Thanks @catriona-m.

Although the mssql tests take a while and the testing scenario for this is more involved, I'm wondering whether it would still be feasible to add a test for this using data.CheckWithClientForResource to simulate the testing steps? Here is a test with an example of what I mean from the AKS default node pool rotation tests, where we simulate different scenarios using data.CheckWithClientForResource

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_scaling_resource_test.go

Line 44 in 5ee7ee5

func TestAccKubernetesCluster_updateVmSizeAfterFailureWithTempAndDefault(t *testing.T) {

.

[catriona-m]

Thanks @catriona-m.

Although the mssql tests take a while and the testing scenario for this is more involved, I'm wondering whether it would still be feasible to add a test for this using data.CheckWithClientForResource to simulate the testing steps? Here is a test with an example of what I mean from the AKS default node pool rotation tests, where we simulate different scenarios using data.CheckWithClientForResource

terraform-provider-azurerm/internal/services/containers/kubernetes_cluster_scaling_resource_test.go

Line 44 in 5ee7ee5

func TestAccKubernetesCluster_updateVmSizeAfterFailureWithTempAndDefault(t *testing.T) {

.

Thanks for the review @stephybun. I had a look at adding a test like this but it was difficult to retrieve the RestorableDatabaseID after deleting the db because the id contains the deletion time.

[stephybun]

Thanks @catriona-m LGTM 👍