Add optional EnablePrivateLinkFastPath to Virtual Network Gateway Connection resource

[fjaeckel]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

In line with #25596, this PR adds support for EnablePrivateLinkFastPath on Virtual Network Gateway Connections.

The prior implementation was just for Express Route Circuit Connections, but this one specifically is needed as well.

I've also added tests for expressroute scenarios and another one with FastPath enabled.

This feature is optional, but ExpressRouteGatewayBypass is required to be enabled and the VirtualNetworkGateway type must be a ExpressRoute gateway.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_virtual_network_gateway_connection - support for private_link_fast_path_enabled property on expressroute type connections. [Add optional EnablePrivateLinkFastPath to Virtual Network Gateway Connection resource #25650]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Relates to #25596
cc/ @stephybun

[stephybun]

Have some test failures

------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_expressroute
=== PAUSE TestAccVirtualNetworkGatewayConnection_expressroute
=== CONT  TestAccVirtualNetworkGatewayConnection_expressroute
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: Creating/Updating Virtual Network Gateway: (Name "acctest-240417152850514852" / Resource Group "acctestRG-240417152850514852"): network.VirtualNetworkGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="PublicIpWithBasicSkuNotAllowedOnExpressRouteGateways" Message="Basic IP configuration for ExpressRoute Virtual Network Gateways is not supported. Please create and associate a Standard IP. /subscriptions/*******/resourceGroups/acctestRG-240417152850514852/providers/Microsoft.Network/virtualNetworkGateways/acctest-240417152850514852" Details=[]
          with azurerm_virtual_network_gateway.test,
          on terraform_plugin_test.tf line 81, in resource "azurerm_virtual_network_gateway" "test":
          81: resource "azurerm_virtual_network_gateway" "test" {
--- FAIL: TestAccVirtualNetworkGatewayConnection_expressroute (410.10s)
FAIL

[fjaeckel]

@stephybun good catch, updated to use Standard SKU.

[stephybun]

Looks like we have a different test failure now:

------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_expressroute
=== PAUSE TestAccVirtualNetworkGatewayConnection_expressroute
=== CONT  TestAccVirtualNetworkGatewayConnection_expressroute
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: Static IP allocation must be used when creating Standard SKU public IP addresses.
          with azurerm_public_ip.test,
          on terraform_plugin_test.tf line 74, in resource "azurerm_public_ip" "test":
          74: resource "azurerm_public_ip" "test" {
--- FAIL: TestAccVirtualNetworkGatewayConnection_expressroute (512.97s)
FAIL

[fjaeckel]

@stephybun apologies, I'm really just winging it. :) That error should be fixed now.

[stephybun]

All good, I was hoping I'd be able to say third time's a charm and approve then merge this but now we have another new failure, looks like the property name for express_route_gateway_bypass_enabled is different in this resource?

------- Stdout: -------
=== RUN   TestAccVirtualNetworkGatewayConnection_expressrouteWithFastPath
=== PAUSE TestAccVirtualNetworkGatewayConnection_expressrouteWithFastPath
=== CONT  TestAccVirtualNetworkGatewayConnection_expressrouteWithFastPath
------- Stderr: -------
panic: interface conversion: interface {} is nil, not bool
goroutine 867 [running]:
github.com/hashicorp/terraform-provider-azurerm/internal/services/network.getVirtualNetworkGatewayConnectionProperties(0x6fc23ac00?, {{0xc00088f9e0}, 0xc0025a0460, 0x0, 0xc001b689b0, 0xc001b689a0, 0xc001b68ab0, 0xc001b689c0, 0xc001b689d0, 0xc00557b830})
  /opt/teamcity-agent/work/3337027aeff310bf/internal/services/network/virtual_network_gateway_connection_resource.go:713 +0x122d
github.com/hashicorp/terraform-provider-azurerm/internal/services/network.resourceVirtualNetworkGatewayConnectionCreateUpdate(0xc0053d8c80, {0x7ac8e60?, 0xc003725200})
  /opt/teamcity-agent/work/3337027aeff310bf/internal/services/network/virtual_network_gateway_connection_resource.go:393 +0x80c
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).create(0x94a2cb8?, {0x94a2cb8?, 0xc0057a70b0?}, 0xd?, {0x7ac8e60?, 0xc003725200?})
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:766 +0x163
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).Apply(0xc001248540, {0x94a2cb8, 0xc0057a70b0}, 0xc002b06000, 0xc0053d8b00, {0x7ac8e60, 0xc003725200})
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:909 +0xa89
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ApplyResourceChange(0xc004219f50, {0x94a2cb8?, 0xc0057a7020?}, 0xc005631c70)
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/grpc_provider.go:1060 +0xdbc
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ApplyResourceChange(0xc0042237c0, {0x94a2cb8?, 0xc0057a6810?}, 0xc005324460)
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server/server.go:859 +0x56b
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ApplyResourceChange_Handler({0x874a9a0?, 0xc0042237c0}, {0x94a2cb8, 0xc0057a6810}, 0xc0053243f0, 0x0)
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:467 +0x169
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0050565a0, {0x94cbd40, 0xc001b56b60}, 0xc005328000, 0xc0012bf320, 0xf0a9ab8, 0x0)
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:1374 +0xde7
google.golang.org/grpc.(*Server).handleStream(0xc0050565a0, {0x94cbd40, 0xc001b56b60}, 0xc005328000, 0x0)
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:1751 +0x9e7
google.golang.org/grpc.(*Server).serveStreams.func1.1()
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:986 +0xbb
created by google.golang.org/grpc.(*Server).serveStreams.func1 in goroutine 410
  /opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:997 +0x145

[fjaeckel]

@stephybun indeed, this resource uses express_route_gateway_bypass without _enabled, I fixed the copy&paste mistake, should do the right things now. 🤞

At least the expressroute test is passing. 😄

[stephybun]

We got there in the end.. nearly. Just the data source docs need updating then this is good to go!

[stephybun]

Thanks @fjaeckel LGTM 🌸