Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpubsub: fixing a panic where networkACL.PublicNetwork.Deny was nil #25886

Merged
merged 1 commit into from
May 8, 2024
Merged

webpubsub: fixing a panic where networkACL.PublicNetwork.Deny was nil #25886

merged 1 commit into from
May 8, 2024

Conversation

tombuildsstuff
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes #25855

Changelog

* `azurerm_web_pubsub_network_acl` - fixing a crash when `networkACL.PublicNetwork.Deny` was nil

@tombuildsstuff tombuildsstuff added this to the v3.103.0 milestone May 7, 2024
@tombuildsstuff tombuildsstuff changed the title webpubsub: fixing a panic where networkACL.PublicNetwork.Deny was ni webpubsub: fixing a panic where networkACL.PublicNetwork.Deny was nil May 7, 2024
@tombuildsstuff tombuildsstuff requested a review from a team May 7, 2024 13:24
@tombuildsstuff tombuildsstuff merged commit bb28b69 into main May 8, 2024
29 checks passed
@tombuildsstuff tombuildsstuff deleted the b/crash-webpubsub-25855 branch May 8, 2024 13:48
tombuildsstuff added a commit that referenced this pull request May 8, 2024
@tombuildsstuff
updating to include #25886
0e9b08f
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
bug crash service/signalr service/web-pub-sub size/XS
Projects
None yet
Milestone
v3.103.0
2 participants
@tombuildsstuff @manicminer