Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix a persistent diff for PIM role assignments with no ticket information #26059

Merged
merged 2 commits into from
May 22, 2024

Conversation

manicminer
Copy link
Member

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_pim_active_role_assignment - fix a persistent diff when ticket is not specified
  • azurerm_pim_eligible_role_assignment - fix a persistent diff when ticket is not specified

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Resolves: #26050

@manicminer manicminer added this to the v3.105.0 milestone May 22, 2024
@manicminer manicminer requested a review from a team May 22, 2024 14:14
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manicminer manicminer force-pushed the bugfix/pim-role-assignment-computed-ticket branch from 6fde3a3 to 6fff544 Compare May 22, 2024 23:05
@manicminer
Copy link
Member Author

Test results

Screenshot 2024-05-23 at 00 51 33

@manicminer manicminer merged commit 0bfdb5d into main May 22, 2024
29 checks passed
@manicminer manicminer deleted the bugfix/pim-role-assignment-computed-ticket branch May 22, 2024 23:52
manicminer added a commit that referenced this pull request May 22, 2024
Copy link

This functionality has been released in v3.105.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not specifying ticket block in azurerm_pim_eligible_role_assignment resource forces recreation
2 participants