azurerm_machine_learning_compute_cluster change subnet_resource_id constraint: Respect Managed Vnet when creating compute clusters fixes #25901

[hmrc87]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

When a Managed Vnet Setup as described in the Microsoft documentation is used a compute cluster can have NO public IP and we don't need to provide a subnet_resource_id since this is managed by Microsoft.

I have tested this setup by creating a compute cluster via cli/sdk and also querying an existing compute cluster. I both cases the subnet_ressource_id can be / was empty/null.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Change Log

• azurerm_machine_learning_compute_cluster - subnet_ressource_id is not mandatory when node_public_ip_enabled if in a managed vnet sceenario [azurerm_machine_learning_compute_cluster subnet_resource_id should be optional, even though node_public_ip_enabled is false #25901]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25901

[stephybun]

Thanks @hmrc87. Although part of the code was just moved from what already existed I left a couple of suggestions on the error messages which would be good to update so that they're more consistent with the rest of the provider. We also need to add some more nil checks. Once that's been fixed up we can run the tests and see if this is ready to go!

[stephybun]

Thanks @hmrc87, I overlooked the removal of the import required error message. Could you add that back in? Should fix the test failure that I'm seeing.

[hmrc87]

@stephybun I will fix all the linter and tests errors asap

[stephybun]

Fantastic, thanks @hmrc87 LGTM 👍

[github-actions]

This functionality has been released in v3.105.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!