Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_groups - allow windows container groups to be created with a User Assigned Identity #26308

Merged

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Jun 12, 2024

Community Note

  • Please vote on this PR by adding a 馃憤 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The linked Azure Rest API specs issues appears to have been resolved, so this is closed now.

Testing

image

Failed test cases are on main

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_container_group - Container Groups running on Windows can be created with a User Assigned Identity [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #24809

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephybun stephybun merged commit d883408 into main Jun 13, 2024
30 checks passed
@stephybun stephybun deleted the f/allow-managed-identity-for-windows-container-group branch June 13, 2024 05:54
@github-actions github-actions bot added this to the v3.108.0 milestone Jun 13, 2024
stephybun added a commit that referenced this pull request Jun 13, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 18, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.107.0&#34; to &#34;3.108.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.108.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.108.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source:** `azurerm_role_management_policy`
([#25900](https://github.com/hashicorp/terraform-provider-azurerm/issues/25900))&#xA;*
**New Resource:** `azurerm_role_management_policy`
([#25900](https://github.com/hashicorp/terraform-provider-azurerm/issues/25900))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
provider: support subscription ID hinting when using Azure CLI
authentication
([#26282](https://github.com/hashicorp/terraform-provider-azurerm/issues/26282))&#xA;*
`serviceconnector`: updating to use API Version `2024-04-01`
([#26248](https://github.com/hashicorp/terraform-provider-azurerm/issues/26248))&#xA;*
`azurerm_container_groups` - can now be created with a User Assigned
Identity when running Windows
([#26308](https://github.com/hashicorp/terraform-provider-azurerm/issues/26308))&#xA;*
`azurerm_kubernetes_cluster` - updating the
`network_profile.network_policy` property to `azure` and `calico` when
it hasn&#39;t been previously set is supported
([#26176](https://github.com/hashicorp/terraform-provider-azurerm/issues/26176))&#xA;*
`azurerm_kubernetes_cluster` - respect Pod Distruption Budgets when
rotating the `default_node_pool`
([#26274](https://github.com/hashicorp/terraform-provider-azurerm/issues/26274))&#xA;*
`azurerm_lb_backend_address_pool` - support for the `synchronous_mode`
property
([#26309](https://github.com/hashicorp/terraform-provider-azurerm/issues/26309))&#xA;*
`azurerm_private_endpoint` - support symultaneous creation of multiple
resources of this type per subnet
([#26006](https://github.com/hashicorp/terraform-provider-azurerm/issues/26006))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_express_route_circuit_peering`,
`azurerm_express_route_circuit`, `azurerm_express_route_gateway`,
`azurerm_express_route_port` - split create and update
([#26237](https://github.com/hashicorp/terraform-provider-azurerm/issues/26237))&#xA;*
`azurerm_lb_backend_address_pool_address` - when using this resource,
values are no longer reset on `azurerm_lb_backend_address_pool`
([#26264](https://github.com/hashicorp/terraform-provider-azurerm/issues/26264))&#xA;*
`azurerm_route_filter` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](https://github.com/hashicorp/terraform-provider-azurerm/issues/26266))&#xA;*
`azurerm_route_server` - spliting create and update so lifecycle ignore
changes works correctly
([#26266](https://github.com/hashicorp/terraform-provider-azurerm/issues/26266))&#xA;*
`azurerm_synapse_workspace` - updates the client used in all operations
of `azurerm_synapse_workspace_sql_aad_admin` to prevent this resource
from modifying the same resource as
`azurerm_synapse_workspace_aad_admin`
([#26317](https://github.com/hashicorp/terraform-provider-azurerm/issues/26317))&#xA;*
`azurerm_virtual_network` - correctly parse network securty group IDs
([#26283](https://github.com/hashicorp/terraform-provider-azurerm/issues/26283))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
Data Source: `azurerm_network_interface` - the `enable_ip_forwarding`
and `enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](https://github.com/hashicorp/terraform-provider-azurerm/issues/26293))&#xA;*
`azurerm_api_management` - the `policy` block has been deprecated is
superseded by the `azurerm_api_management_policy` resource
([#26305](https://github.com/hashicorp/terraform-provider-azurerm/issues/26305))&#xA;*
`azurerm_kubernetes_cluster` - the `ebpf_data_plane` property has been
deprecated and superseded by the `network_data_plane` property
([#26251](https://github.com/hashicorp/terraform-provider-azurerm/issues/26251))&#xA;*
`azurerm_network_interface` - the `enable_ip_forwarding` and
`enable_accelerated_networking` properties have been deprecated and
superseded by the `ip_forwarding_enabled` and
`accelerated_networking_enabled` properties
([#26293](https://github.com/hashicorp/terraform-provider-azurerm/issues/26293))&#xA;*
`azurerm_synapse_workspace` - the `aad_admin` and `sql_aad_admin` blocks
have been deprecated and superseded by the
`azurerm_synapse_workspace_aad_admin` and
`azurerm_synapse_workspace_sql_aad_admin` resources
([#26317](https://github.com/hashicorp/terraform-provider-azurerm/issues/26317))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/244/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_container_group does not provision user assigned managed identity
2 participants