azurerm_kubernetes_cluster
/azurerm_kubernetes_cluster_node_pool
- prevent a plan diff when API returns an empty upgrade_settings
object
#26541
+15
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
The API returns an empty
upgrade_settings
object in certain instances, we need to check if any values are present when flattening to prevent Terraform from showing a diff.In addition, this PR also rolls back a planned 4.0 change in the
upgrade_settings
block, this needs to remainOptional
because there are scenarios where it cannot be supplied e.g. spot node pools.Also removes
public_network_access_enabled
from the schema in 4.0 since this property still doesn't appear to be functional. Can be reintroduced at a later stage once it's working.Testing
Running ...
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_kubernetes_cluster
- prevent a diff inupgrade_settings
when the API returns an empty object [GH-00000]azurerm_kubernetes_cluster_node_pool
- prevent a diff inupgrade_settings
when the API returns an empty object [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #26280
Fixes #26465
Note
If this PR changes meaningfully during the course of review please update the title and description as required.