Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is_hns_enabled to storage account for data lake storage gen2 #3032

Merged

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Mar 12, 2019

Added already an issue for this PR: issue

I also fixed a problem in the documentation for the storage account for which created a comment here

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left a couple of minor comments in-line, but this otherwise LGTM 👍. Since these comments are a couple of minor documentation changes I hope you don't mind but I'm going to push a commit to fix these, so that we can get this merged.

Thanks!

website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
website/docs/d/storage_account.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Member

Ignoring a known test failure, the tests look good:

Screenshot 2019-03-18 at 11 40 38

Thanks again for this @r0bnet

@tombuildsstuff tombuildsstuff merged commit f827216 into hashicorp:master Mar 18, 2019
tombuildsstuff added a commit that referenced this pull request Mar 18, 2019
@TheMacStack
Copy link

hello, will this be in the next release?

@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 17, 2019
@r0bnet r0bnet deleted the storage-account_is_hns_enabled branch May 2, 2019 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants