Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for multiple network profiles in virtual machine scale set model #378

Merged
merged 1 commit into from Oct 16, 2017

Conversation

dominik-lekse
Copy link
Contributor

This pull request add the test case TestAccAzureRMVirtualMachineScaleSet_multipleNetworkProfiles which tests creating a virtual machine scale set with multiple network_profiles. This is currently allowed by the Terraform schema and the documentation of the azurerm_virtual_machine_scale_set resource but fails since the currently used version of the Azure SDK for Go applies the Azure API version 2016-04-30-preview for managing virtual machine scale sets.

The pull request #367 upgrades to v11 of the Azure SDK for Go which uses the Azure API version 2017-03-30 for managing virtual machine scale sets. Thus, this test will turn green after #367 is merged confirming the feature of using multiple network profiles.

make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMVirtualMachineScaleSet_multipleNetworkProfiles'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMVirtualMachineScaleSet_multipleNetworkProfiles -timeout 120m
=== RUN   TestAccAzureRMVirtualMachineScaleSet_multipleNetworkProfiles
--- FAIL: TestAccAzureRMVirtualMachineScaleSet_multipleNetworkProfiles (96.34s)
	testing.go:434: Step 0 error: Error applying: 1 error(s) occurred:

		* azurerm_virtual_machine_scale_set.test: 1 error(s) occurred:

		* azurerm_virtual_machine_scale_set.test: compute.VirtualMachineScaleSetsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="MinimumApiVersionNotSpecifiedForMultiNetworkInterfaceConfigurationOnVMScaleSet" Message="Specified api-version 2016-04-30-preview does not meet the minimum required api-version 2017-03-30 for multiple network interface configurations on VM Scale Set. Use api-version 2017-03-30 or higher to use multiple network interface configurations on VM Scale Set." Details=[]
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm	96.363s
make: *** [testacc] Error 1

…Profiles` for multiple network profiles in virtual machine scale set model
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dominik-lekse

Thanks for this PR - I've taken a look and this LGTM. As you've mentioned this is blocked on #367 - and we'll merge this after that :)

Thanks!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants