Making the azurerm_client_config data source work with AzureCLI auth

[tombuildsstuff]

Fixes #392

Unfortunately testing this is tricky, since we rely on a Service Principal to run the acceptance tests (and not AzureCLI auth) - however I've verified this works as expected in both cases

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMClientConfig_basic
=== RUN   TestAccDataSourceAzureRMClientConfig_basic
--- PASS: TestAccDataSourceAzureRMClientConfig_basic (12.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	12.673s

[radeksimko]

LGTM, although I don't know much about service principles nor Azure, so take that with a pinch of salt.

[radeksimko]

🙀

[radeksimko]

Nitpick, but using* to me sounds like a state that may be managed from somewhere outside, how do you feel about calling it useServicePrinciple instead?

[tombuildsstuff]

it will be managed from somewhere outside (it's determined in the Config class, and then cast to an ArmConfig once the authentication tokens have been obtained) - as such I think using makes more sense in this context than use? That said, I'm happy to change this - but I'm a little stumped for a better name ¯_(ツ)_/¯

[tombuildsstuff]

(merging this for the moment - we can rename this later if needed)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!