Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_route_table - removing routes when none are specified #403

Merged
merged 1 commit into from Oct 6, 2017

Conversation

tombuildsstuff
Copy link
Member

Removing Route's when none are defined. Fixes #39

New test:

$ acctests azurerm TestAccAzureRMRouteTable_removeRoute
=== RUN   TestAccAzureRMRouteTable_removeRoute
--- PASS: TestAccAzureRMRouteTable_removeRoute (93.89s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    93.914s

Running the suite now

```
$ acctests azurerm TestAccAzureRMRouteTable_removeRoute
=== RUN   TestAccAzureRMRouteTable_removeRoute
--- PASS: TestAccAzureRMRouteTable_removeRoute (93.89s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm    93.914s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Member Author

Test suite:

$ acctests azurerm TestAccAzureRMRouteTable_
=== RUN   TestAccAzureRMRouteTable_importBasic
--- PASS: TestAccAzureRMRouteTable_importBasic (79.32s)
=== RUN   TestAccAzureRMRouteTable_importSingleRoute
--- PASS: TestAccAzureRMRouteTable_importSingleRoute (77.49s)
=== RUN   TestAccAzureRMRouteTable_importMultipleRoutes
--- PASS: TestAccAzureRMRouteTable_importMultipleRoutes (77.34s)
=== RUN   TestAccAzureRMRouteTable_basic
--- PASS: TestAccAzureRMRouteTable_basic (77.00s)
=== RUN   TestAccAzureRMRouteTable_singleRoute
--- PASS: TestAccAzureRMRouteTable_singleRoute (77.32s)
=== RUN   TestAccAzureRMRouteTable_removeRoute
--- PASS: TestAccAzureRMRouteTable_removeRoute (95.84s)
=== RUN   TestAccAzureRMRouteTable_disappears
--- PASS: TestAccAzureRMRouteTable_disappears (78.29s)
=== RUN   TestAccAzureRMRouteTable_withTags
--- PASS: TestAccAzureRMRouteTable_withTags (86.23s)
=== RUN   TestAccAzureRMRouteTable_multipleRoutes
--- PASS: TestAccAzureRMRouteTable_multipleRoutes (95.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	744.237s

@tombuildsstuff tombuildsstuff merged commit c695631 into master Oct 6, 2017
@tombuildsstuff tombuildsstuff deleted the route-table-rules branch October 6, 2017 14:27
tombuildsstuff added a commit that referenced this pull request Oct 6, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_route does not delete routes associated with the table when removed
2 participants