Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the possibility to add an Azure VNET/Subnet to access an Azure Container Registery (Firewalls and virtual networks) #4236

Closed
Imed-Eden opened this issue Sep 4, 2019 · 3 comments · Fixed by #4293

Comments

@Imed-Eden
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We want to restrain the network access to our ACR (Azure Container Registry). For this, from the portal we have the ability to use the feature called Firewalls and virtual networks and select a specific VNET/Subnet to be able to access the ACR. However, Terraform does not seem to be able to provide us an attribute to configure that.

Currently, it appears that we can only use network_rule_set that supports the following:

  • default_action
  • ip_rule

So we can only specify CIDR or a public IP but what about a specific subnet inside a VNET? Because we can configure that for other services like Account Storage using the virtual_network_subnet_ids :

network_rules {
    default_action             = "Deny"
    bypass                     = ["AzureServices"]
    virtual_network_subnet_ids = ["${azurerm_subnet.test.id}"]
}

New or Affected Resource(s)

Terraform v0.12.7

  • provider.azurerm v1.33.1

Terraform Configuration

  network_rule_set {
       default_action             = "Deny"
  }

Thank you in advance :)

@r0bnet
Copy link
Contributor

r0bnet commented Sep 10, 2019

Should be fixed with: #4293

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants