Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: support for enable_node_public_ip in agent_pool_profile #4613

Merged
merged 2 commits into from Oct 30, 2019
Merged

Conversation

topikettunen
Copy link
Contributor

@topikettunen topikettunen commented Oct 14, 2019

Adds support for enabling node's public IP in agent_pool_profile with simple boolean flag as requested by #4581.

For example:

agent_pool_profile {
    name                  = "default"
    count                 = 1
    vm_size               = "Standard_D2_v2"
    os_type               = "Linux"
    os_disk_size_gb       = 30
    type                  = "VirtualMachineScaleSets"
    enable_node_public_ip = true
}

Things to notice: Since this is update that is only available in AKS preview so you need to enable following feature Microsoft.ContainerService/NodePublicIPPreview.

@ghost ghost added the size/M label Oct 14, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @topikettunen, these changes look mostly good but there are just a couple oddities to fix up.

azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kubernetes_cluster.go Outdated Show resolved Hide resolved
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Add support for adding node's public IP in agent_pool_profile azurerm_kubernetes_cluster: support for enable_node_public_ip in agent_pool_profile Oct 30, 2019
@mbfrahry mbfrahry added this to the v1.37.0 milestone Oct 30, 2019
@mbfrahry mbfrahry merged commit c0dbcac into hashicorp:master Oct 30, 2019
@mbfrahry
Copy link
Member

Thanks for this @topikettunen. This should make it into 1.37.0 of the provider

@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants