Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WNS and other Notification Hub credentials in azurerm_notification_hub #4629

Open
Structed opened this issue Oct 16, 2019 · 1 comment

Comments

@Structed
Copy link

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Azure Provider currently seems not to support WNS, Amazon and Baidu credentials.
These credential types would be very necessary to fully use Notification Hubs - particularly the WNS support.

Affected Resource

  • azurerm_notification_hub

Potential Terraform Configuration

resource "azurerm_resource_group" "test" {
  name     = "notificationhub-resources"
  location = "Australia East"
}

resource "azurerm_notification_hub_namespace" "test" {
  name                = "myappnamespace"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"
  namespace_type      = "NotificationHub"

  sku_name = "Free"
}

resource "azurerm_notification_hub" "test" {
  name                = "mynotificationhub"
  namespace_name      = "${azurerm_notification_hub_namespace.test.name}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"

  wns_credential {
      package_sid  = "ms-app://S-1-15-0-0000000000-1111111111-2222222222-333333333-4444444444-5555555555-6666666666"
      security_key = "dsfadfskfjasdhf78zzfasdf"
  }

  # Use similar for Amazon, Baidu
}

References

https://www.terraform.io/docs/providers/azurerm/r/notification_hub.html

@Structed Structed changed the title Support WNS and other Notification Hub credentials in azurerm_notification_hub Support WNS and other Notification Hub credentials in azurerm_notification_hub Oct 16, 2019
@worldspawn
Copy link

Browser push is also now supported by Notification Hub and is another set of credentials needing TF support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants