azurerm_private_dns_ptr_record - new resource type (#4691) #4703
Conversation
ghost
added
There was a problem hiding this comment.
hey @phires
Thanks for this PR :)
Taking a look through this is looking good - if we can fix up the minor issues (and the tests pass) then this otherwise LGTM 👍
Thanks!
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
There was a problem hiding this comment.
hey @phires
Thanks for pushing those changes - taking a look through aside from a missing sidebar link this otherwise LGTM 👍
Thanks!
| Manages a Private DNS PTR Record. | ||
| --- | ||
|
|
||
| # azurerm_private_dns_ptr_record |
There was a problem hiding this comment.
we need to add a link for this page in the sidebar: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/azurerm.erb#L1654-L1664
|
Tests pass:
|
|
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes issue #4691 (private_dns_zone does not support PTR records)